From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatoly Burakov Subject: [PATCH 18.05 v4] Add function to return number of detected sockets Date: Wed, 7 Feb 2018 09:58:35 +0000 Message-ID: References: <750e30c6dcc7a22a87df9c56fb824042b1db984f.1517848624.git.anatoly.burakov@intel.com> To: dev@dpdk.org Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 561611B790 for ; Wed, 7 Feb 2018 10:58:39 +0100 (CET) Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id w179wa8X018854 for ; Wed, 7 Feb 2018 09:58:36 GMT Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id w179waCL025911 for ; Wed, 7 Feb 2018 09:58:36 GMT Received: (from aburakov@localhost) by sivswdev01.ir.intel.com with LOCAL id w179waoW025907 for dev@dpdk.org; Wed, 7 Feb 2018 09:58:36 GMT In-Reply-To: <750e30c6dcc7a22a87df9c56fb824042b1db984f.1517848624.git.anatoly.burakov@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch is for 18.05 and implements changes referenced in the deprecation notice[1]. (not yet merged as of this writing) This patchset breaks the EAL ABI and bumps its version. This is arguably OK as memory changes will change a lot in EAL and thus likely break ABI anyway. However, two other alternative implementations are possible: 1) local static variable recording number of detected sockets. This is arguably less clean approach, but will not break the ABI and will have relatively little impact on the codebase. 2) keeping ABI compatibility, as shown in v3 of this patch [2]. My preference would be to keep this one. [1] http://dpdk.org/dev/patchwork/patch/33853/ [2] http://dpdk.org/dev/patchwork/patch/34994/ Anatoly Burakov (1): eal: add function to return number of detected sockets lib/librte_eal/bsdapp/eal/Makefile | 2 +- lib/librte_eal/common/eal_common_lcore.c | 37 +++++++++++++++++++++---------- lib/librte_eal/common/include/rte_eal.h | 1 + lib/librte_eal/common/include/rte_lcore.h | 8 +++++++ lib/librte_eal/linuxapp/eal/Makefile | 2 +- lib/librte_eal/rte_eal_version.map | 9 +++++++- 6 files changed, 44 insertions(+), 15 deletions(-) -- 2.7.4