public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org
Subject: [PATCH v3 0/8] Reduce reliance on global response buffer in IAVF
Date: Fri,  6 Mar 2026 10:58:16 +0000	[thread overview]
Message-ID: <cover.1772794442.git.anatoly.burakov@intel.com> (raw)
In-Reply-To: <2a3001591642339ecf8f91584c83bf0766e0b66d.1772021348.git.anatoly.burakov@intel.com>

In many places where we are calling down into virtchnl, we are using a
globally allocated adminq response buffer. This is unnecessary, so replace
with adminq buffers allocated on stack. However, because IAVF virtchnl
message queue works asynchronously in most cases, we can't remove the
global buffer entirely, and we need to do some cleanup and refactoring to
be able to reduce our usage of these buffers. This patchset does that.

v1 -> v2:
- Stats query was passing in a pointer-to-pointer and storing pointer to
  global adminq response buffer as output parameter, so changing that to a
  local buffer resulted in storing a pointer to a buffer that was stack
  allocated (i.e. introduced a use-after-free).

v2 -> v3:
- Reworked the virtchnl message handling to not rely on implicit behavior
- Split up into 8 patches for easy review

Anatoly Burakov (8):
  net/iavf: avoid passing around pointers
  net/iavf: add a variable for hena
  net/iavf: add virtchnl interrupt enable flag
  net/iavf: rework "async" virtchnl requests
  net/iavf: refactor sending virtchnl messages
  net/iavf: respect output buffer in virtchnl
  net/iavf: do not use global virtchnl buffer
  net/iavf: embed virtchnl response buffer

 drivers/net/intel/iavf/iavf.h        |  58 +---
 drivers/net/intel/iavf/iavf_ethdev.c |  50 ++-
 drivers/net/intel/iavf/iavf_vchnl.c  | 483 ++++++++++++++++-----------
 3 files changed, 304 insertions(+), 287 deletions(-)

-- 
2.47.3


  parent reply	other threads:[~2026-03-06 10:58 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 12:09 [PATCH v1 1/1] net/iavf: remove global adminq response buffer Anatoly Burakov
2026-02-26 10:41 ` [PATCH v2 " Anatoly Burakov
2026-02-26 10:52   ` Burakov, Anatoly
2026-02-27 10:58   ` Bruce Richardson
2026-03-03  8:52     ` Bruce Richardson
2026-03-06 10:58 ` Anatoly Burakov [this message]
2026-03-06 10:58   ` [PATCH v3 1/8] net/iavf: avoid passing around pointers Anatoly Burakov
2026-04-03 10:37     ` Bruce Richardson
2026-03-06 10:58   ` [PATCH v3 2/8] net/iavf: add a variable for hena Anatoly Burakov
2026-04-03 10:39     ` Bruce Richardson
2026-03-06 10:58   ` [PATCH v3 3/8] net/iavf: add virtchnl interrupt enable flag Anatoly Burakov
2026-04-03 10:42     ` Bruce Richardson
2026-03-06 10:58   ` [PATCH v3 4/8] net/iavf: rework "async" virtchnl requests Anatoly Burakov
2026-04-03 10:52     ` Bruce Richardson
2026-03-06 10:58   ` [PATCH v3 5/8] net/iavf: refactor sending virtchnl messages Anatoly Burakov
2026-04-03 10:55     ` Bruce Richardson
2026-03-06 10:58   ` [PATCH v3 6/8] net/iavf: respect output buffer in virtchnl Anatoly Burakov
2026-04-03 11:08     ` Bruce Richardson
2026-03-06 10:58   ` [PATCH v3 7/8] net/iavf: do not use global virtchnl buffer Anatoly Burakov
2026-04-03 11:10     ` Bruce Richardson
2026-03-06 10:58   ` [PATCH v3 8/8] net/iavf: embed virtchnl response buffer Anatoly Burakov
2026-04-03 11:11     ` Bruce Richardson
2026-04-03 13:13   ` [PATCH v3 0/8] Reduce reliance on global response buffer in IAVF Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1772794442.git.anatoly.burakov@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox