From: Zhang Tengfei <zhtfdev@gmail.com>
To: dev@dpdk.org
Cc: stephen@networkplumber.org, Zhang Tengfei <zhtfdev@gmail.com>,
jiawenwu@trustnetic.com, zaiyuwang@trustnetic.com
Subject: [PATCH 0/3] net/txgbe: fix FDIR Rx packet buffer handling
Date: Tue, 13 Oct 2026 22:00:16 +0800 [thread overview]
Message-ID: <cover.1791898970.git.zhtfdev@gmail.com> (raw)
Enabling Flow Director reduces the Rx packet buffer 0 to reserve memory
for the filter table, but the size was computed from the current
register value and never restored when FDIR was no longer used. Since
the FDIR mode is reset when the last rule is removed, on flush, or when
enabling FDIR fails, the next rule enabled FDIR again and shrank the
buffer once more, until it underflowed. Validating a rule also enabled
FDIR.
Patch 1 computes the buffer size from the default packet buffer size,
which alone stops the repeated reduction.
Patch 2 stops enabling FDIR from flow validate and rolls back the mode
when the first rule fails.
Patch 3 disables FDIR and restores the buffer when no rule is left.
The same issue was fixed in ixgbe:
<https://patches.dpdk.org/project/dpdk/patch/20260927042545.45152-1-zhtfdev@gmail.com>
Compile tested only.
Zhang Tengfei (3):
net/txgbe: fix Rx packet buffer size with flow director
net/txgbe: do not enable flow director on flow validate
net/txgbe: disable flow director when no rule is left
drivers/net/txgbe/txgbe_ethdev.h | 1 +
drivers/net/txgbe/txgbe_fdir.c | 36 +++++++++++++++----
drivers/net/txgbe/txgbe_flow.c | 60 +++++++++++++++++---------------
3 files changed, 62 insertions(+), 35 deletions(-)
--
2.53.0
next reply other threads:[~2026-10-13 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 14:00 Zhang Tengfei [this message]
2026-10-13 14:00 ` [PATCH 1/3] net/txgbe: fix Rx packet buffer size with flow director Zhang Tengfei
2026-10-13 14:00 ` [PATCH 2/3] net/txgbe: do not enable flow director on flow validate Zhang Tengfei
2026-10-13 14:00 ` [PATCH 3/3] net/txgbe: disable flow director when no rule is left Zhang Tengfei
2026-10-13 14:45 ` [PATCH 0/3] net/txgbe: fix FDIR Rx packet buffer handling Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1791898970.git.zhtfdev@gmail.com \
--to=zhtfdev@gmail.com \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=stephen@networkplumber.org \
--cc=zaiyuwang@trustnetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox