From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Hunt, David" <david.hunt@intel.com>
Subject: Re: [PATCH] examples: fix RSS hash function configuration
Date: Wed, 20 Jun 2018 16:11:50 +0100
Message-ID: <d00e6b84-ac5a-dae0-fba6-5f40d0bf69b2@intel.com>
References: <20180620150122.45945-1-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Liang Ma <liang.j.ma@intel.com>,
 Xueming Li <xuemingl@mellanox.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 Declan Doherty <declan.doherty@intel.com>, Chas Williams <chas3@att.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Harry van Haaren <harry.van.haaren@intel.com>,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Remy Horton <remy.horton@intel.com>, Ori Kam <orika@mellanox.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>,
 Radu Nicolau <radu.nicolau@intel.com>, Akhil Goyal <akhil.goyal@nxp.com>,
 Tomasz Kantecki <tomasz.kantecki@intel.com>,
 Anatoly Burakov <anatoly.burakov@intel.com>,
 John McNamara <john.mcnamara@intel.com>, Jijiang Liu <jijiang.liu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 75EC81B522
 for <dev@dpdk.org>; Wed, 20 Jun 2018 17:10:21 +0200 (CEST)
In-Reply-To: <20180620150122.45945-1-ferruh.yigit@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ferruh,


On 20/6/2018 4:01 PM, Ferruh Yigit wrote:
> ethdev layer introduced checks for application requested RSS hash
> functions and returns error for ones unsupported by hardware
>
> This check breaks some sample applications which blindly configures
> RSS hash functions without checking underlying hardware support.
>
> Updated examples to mask out unsupported RSS has functions during device
> configuration.
> Prints a log if configuration values updated by this check.
>
> Fixes: aa1a6d87f15d ("ethdev: force RSS offload rules again")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Return error added in this release, so no need to backport the fix to
> previous versions.
>
> Cc: David Hunt <david.hunt@intel.com>
> Cc: Liang Ma <liang.j.ma@intel.com>
> Cc: Xueming Li <xuemingl@mellanox.com>
> ---
>   examples/bond/main.c                          | 12 ++++++++++
>   examples/distributor/main.c                   | 11 ++++++++++
>   examples/eventdev_pipeline/main.c             | 11 ++++++++++
>   examples/ip_pipeline/link.c                   |  8 +++++--
>   examples/ip_reassembly/main.c                 | 12 ++++++++++
>   examples/ipsec-secgw/ipsec-secgw.c            | 12 ++++++++++
>   examples/l3fwd-acl/main.c                     | 12 ++++++++++
>   examples/l3fwd-power/main.c                   | 14 ++++++++++--
>   examples/l3fwd-vf/main.c                      | 12 ++++++++++
>   examples/l3fwd/main.c                         | 12 ++++++++++
>   examples/load_balancer/init.c                 | 12 ++++++++++
>   examples/multi_process/symmetric_mp/main.c    | 12 ++++++++++
>   .../performance-thread/l3fwd-thread/main.c    | 12 ++++++++++
>   examples/qos_meter/main.c                     | 22 +++++++++++++++++++
>   examples/vmdq_dcb/main.c                      | 13 +++++++++++
>   15 files changed, 183 insertions(+), 4 deletions(-)
>
>
--snip--

I tested distributor_app, l3-fwd and l3-fwd-power, they all started OK, 
giving the additional message that some flags were not available on my 
hardware.
Looks good.

Regards,
Dave.