From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v2 12/18] eal: add generic device declaration
	parameter
Date: Wed, 13 Dec 2017 19:56:42 +0530
Message-ID: <d051e00f-42db-a4ac-00ea-adeb07934d76@nxp.com>
References: <cover.1503676587.git.gaetan.rivet@6wind.com>
 <cover.1507796100.git.gaetan.rivet@6wind.com>
 <c16edb4815d830679404fa1012b2989e3ba24f9c.1507796100.git.gaetan.rivet@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam02on0061.outbound.protection.outlook.com [104.47.36.61])
 by dpdk.org (Postfix) with ESMTP id 4EAFE2030
 for <dev@dpdk.org>; Wed, 13 Dec 2017 15:13:12 +0100 (CET)
In-Reply-To: <c16edb4815d830679404fa1012b2989e3ba24f9c.1507796100.git.gaetan.rivet@6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thursday 12 October 2017 01:51 PM, Gaetan Rivet wrote:
> Add a new generic device declaration parameter:
> 
>     --dev=<device_declaration>
> 

[...]

> 
> diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
> index 603df27..b7591fd 100644
> --- a/lib/librte_eal/common/eal_common_options.c
> +++ b/lib/librte_eal/common/eal_common_options.c
> @@ -95,6 +95,7 @@ eal_long_options[] = {
>   	{OPT_PROC_TYPE,         1, NULL, OPT_PROC_TYPE_NUM        },
>   	{OPT_SOCKET_MEM,        1, NULL, OPT_SOCKET_MEM_NUM       },
>   	{OPT_SYSLOG,            1, NULL, OPT_SYSLOG_NUM           },
> +	{OPT_DEV,               1, NULL, OPT_DEV_NUM              },
>   	{OPT_VDEV,              1, NULL, OPT_VDEV_NUM             },
>   	{OPT_VFIO_INTR,         1, NULL, OPT_VFIO_INTR_NUM        },
>   	{OPT_VMWARE_TSC_MAP,    0, NULL, OPT_VMWARE_TSC_MAP_NUM   },
> @@ -1120,6 +1121,21 @@ eal_parse_common_option(int opt, const char *optarg,
>   		}
>   		break;
>   
> +	case OPT_DEV_NUM: {
> +		struct rte_devargs da;
> +		int ret;
> +
> +		if (rte_eal_devargs_parse(&da, optarg) < 0)
> +			return -1;
> +		ret = rte_bus_probe_mode_set(da.bus->name,
> +					RTE_BUS_PROBE_WHITELIST);
> +		if (ret < 0 && ret != -ENOTSUP)
> +			return -1;
> +		if (eal_option_device_add(NULL, optarg) < 0)
> +			return -1;
> +	}

Might be a naive question: Any specific reason why we don't add the 
devices directly into devargs_list here (eal_parse_args -> 
eal_parse_common_option -> OPT_DEV ->) rather than wait for eal to call 
eal_option_device_parse again?

Is it to allow eal_plugins_init() to finish?

> +		break;
> +
>   	case OPT_VDEV_NUM:
>   		if (eal_option_device_add("vdev", optarg) < 0)
>   			return -1;

[...]