From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH v2 4/5] mbuf: pktmbuf pool create helper for
 specific mempool ops
Date: Mon, 15 Jan 2018 20:02:30 +0530
Message-ID: <d0995b7c-702d-4218-f338-950436b52cc7@nxp.com>
References: <1513333483-4372-1-git-send-email-hemant.agrawal@nxp.com>
 <1515996674-26338-1-git-send-email-hemant.agrawal@nxp.com>
 <1515996674-26338-5-git-send-email-hemant.agrawal@nxp.com>
 <20180115123132.GB833@jerin>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <olivier.matz@6wind.com>,
 <santosh.shukla@caviumnetworks.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
 (mail-bl2nam02on0043.outbound.protection.outlook.com [104.47.38.43])
 by dpdk.org (Postfix) with ESMTP id 42C2C28F3
 for <dev@dpdk.org>; Mon, 15 Jan 2018 15:32:36 +0100 (CET)
In-Reply-To: <20180115123132.GB833@jerin>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/15/2018 6:01 PM, Jerin Jacob wrote:
>> Introduce a new helper for pktmbuf pool, which will allow
>> the application to optionally specify the mempool ops name
>> as well.
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>>  lib/librte_mbuf/rte_mbuf.c           | 23 ++++++++++++++------
>>  lib/librte_mbuf/rte_mbuf.h           | 42 ++++++++++++++++++++++++++++++++++++
>>  lib/librte_mbuf/rte_mbuf_version.map |  1 +
>>  3 files changed, 60 insertions(+), 6 deletions(-)
>>
<snip>...
>> +rte_pktmbuf_pool_create_specific(const char *name, unsigned int n,
>
> No strong opinion on name. I think, rte_pktmbuf_pool_create_by_op() may be
> a better name than rte_pktmbuf_pool_create_specific()

yes. looks better. I will change it in next rev.