From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Traynor Subject: Re: [PATCH v5 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Date: Thu, 21 Feb 2019 19:10:09 +0000 Message-ID: References: <20190109085426.39965-1-yskoh@mellanox.com> <20190114211622.6900-1-yskoh@mellanox.com> <20190114211622.6900-2-yskoh@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: olivier.matz@6wind.com, shahafs@mellanox.com, dev@dpdk.org, arybchenko@solarflare.com, roszenrami@gmail.com, david.marchand@redhat.com, stable@dpdk.org To: Yongseok Koh Return-path: In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Yongseok, Can you let me know how you want to proceed with the below. I think we could just drop as it's a performance optimization, or maybe you have a different idea. thanks, Kevin. On 06/02/2019 15:54, Kevin Traynor wrote: > On 01/14/2019 09:16 PM, Yongseok Koh wrote: >> On replenishing Rx buffers for vectorized Rx, mbuf->buf_addr isn't needed >> to be accessed as it is static and easily calculated from the mbuf address. >> Accessing the mbuf content causes unnecessary load stall and it is worsened >> on ARM. >> >> Fixes: 545b884b1da3 ("net/mlx5: fix buffer address posting in SSE Rx") >> Cc: stable@dpdk.org >> > > This is using the API introduced in 1/2, so it's not really suitable for > backport. Maybe you want to send an alternative for stable? > >> Signed-off-by: Yongseok Koh >> Acked-by: Shahaf Shuler >> ---