From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn.topel@intel.com>
Subject: Re: [PATCH] examples/l3fwd: force CRC stripping for
	i40evf
Date: Wed, 9 Nov 2016 14:09:42 +0100
Message-ID: <d17063d2-e617-b9a2-bd68-2086f9aa8cf4@intel.com>
References: <20161109082341.19825-1-bjorn.topel@intel.com>
 <2601191342CEEE43887BDE71AB9772583F0D2F6C@irsmsx105.ger.corp.intel.com>
 <5ad83b54-f13b-787e-c056-958f5cb8bd61@intel.com>
 <2601191342CEEE43887BDE71AB9772583F0D2FD9@irsmsx105.ger.corp.intel.com>
 <b2592ded-badc-5445-526c-d0203b48f592@intel.com>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E717F4AED3@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: "Xu, Qian Q" <qian.q.xu@intel.com>, "Yao, Lei A" <lei.a.yao@intel.com>,
 "Wu, Jingjing" <jingjing.wu@intel.com>,
 "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 34FCB3772
 for <dev@dpdk.org>; Wed,  9 Nov 2016 14:09:45 +0100 (CET)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E717F4AED3@SHSMSX103.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Björn/Konstantin wrote:
>> Finally, why doesn't l3fwd have the CRC stripped?
>
> I don’t know any good reason for that for l3fwd or any other sample
> app. I think it is just a 'historical' reason.

Ok! Then I'd suggest changing the l3fwd default to actually *strip* CRC
instead of not doing it. Lei, any comments?

Helin wrote:
> Yes, i40e driver changed a little bit on that according to the
> review comments during implementation, comparing to igb and ixgbe.
> I'd suggest to re-invesitgate if we can do the similar thing in igb
> and ixgbe driver.

Good. Let's do that!

> Any critical issue now? Or just an improvement comments?

Not from my perspective. The issue is that Lei needs some kind of
work-around for l3fwd with i40evf, so I'll let Lei comment on how
critical it is.


Björn