From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [RFC 0/2] TAP TSO Implementation Date: Mon, 9 Apr 2018 17:38:57 +0100 Message-ID: References: <1520629826-23055-1-git-send-email-ophirmu@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Thomas Monjalon , Olga Shern To: Ophir Munk , dev@dpdk.org, Pascal Mazon Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id D0A851B843 for ; Mon, 9 Apr 2018 18:39:00 +0200 (CEST) In-Reply-To: <1520629826-23055-1-git-send-email-ophirmu@mellanox.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/9/2018 9:10 PM, Ophir Munk wrote: > This RFC suggests TAP TSO (TSP segmentation offload) implementation in SW. > It uses dpdk library rte_gso which is also used by testpmd. > Dpdk rte_gso library segments large TCP payloads (e.g. 64K bytes) > into smaller MTU size buffers. > By supporting TSO offload capability in software a TAP device can be used > as a failsafe sub device and be paired with another PCI device which > supports TSO capability in HW. > > This RFC includes 2 commits: > 1. Calculation of IP/TCP/UDP checksums for multi segments packets. > Previously checksum offload was skipped if the number of packet segments > was greater than 1. > This commit removes this limitation. It is required before supporting TAP TSO > since the generated small TCP packets may be composed by themselves by more than > one segment. > 2. Core TAP TSO implementation: calling rte_gso_segment() segments > large TCP packets. > To be added: creation of a small private mbuf pool in TAP required by librte_gso. > The number of buffers will be 64 - each of 128 bytes length. > > Ophir Munk (2): > net/tap: calculate checksum for multi segs packets > net/tap: implement TAP TSO This is an RFC, and V1 not sent for the patch, is this still valid for this release or should we push into next one?