From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anand Rawat Subject: Re: [PATCH v8 08/10] eal: add minimum viable code for eal on windows Date: Tue, 2 Apr 2019 15:57:47 -0700 Message-ID: References: <20190306041634.12976-1-anand.rawat@intel.com> <20190402035458.14664-1-anand.rawat@intel.com> <20190402035458.14664-9-anand.rawat@intel.com> <3599974.brf36yD2AO@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com To: Thomas Monjalon Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 515775B3E for ; Wed, 3 Apr 2019 00:57:47 +0200 (CEST) In-Reply-To: <3599974.brf36yD2AO@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/2/2019 3:39 PM, Thomas Monjalon wrote: > I think the change below is bad because it is exposing an internal > function in a header file which may be included by apps. > I know you are still looking for pthread integration solutions, > so we can discuss how to fix it later. > > Note that there is already an EAL function to create normal threads: > rte_ctrl_thread_create() > You may want a similar function for dataplane threads perhaps. > > Yes, we can work on removing eal_thread_create and substituting it with rte_ctrl_thread_create. We have been able to macro substitute quite a lot of pthread lib functionality with Microsoft libc. I can start looking into porting those functionalities for rte_ctrl_thread_create() on Windows. -- Anand Rawat