From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH] doc: address the offload API changes for virtio guide Date: Fri, 25 May 2018 09:16:45 +0200 Message-ID: References: <20180525061748.16184-1-tiwei.bie@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: ferruh.yigit@intel.com, dev@dpdk.org To: Tiwei Bie , john.mcnamara@intel.com, marko.kovacevic@intel.com Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 25B59DE0 for ; Fri, 25 May 2018 09:16:50 +0200 (CEST) In-Reply-To: <20180525061748.16184-1-tiwei.bie@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/25/2018 08:17 AM, Tiwei Bie wrote: > Signed-off-by: Tiwei Bie > --- > doc/guides/nics/virtio.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst > index 8922f9c0b..a42d1bb30 100644 > --- a/doc/guides/nics/virtio.rst > +++ b/doc/guides/nics/virtio.rst > @@ -234,7 +234,7 @@ By default, the non-vector callbacks are used: > > Vector callbacks will be used when: > > -* ``txq_flags`` is set to ``VIRTIO_SIMPLE_FLAGS`` (0xF01), which implies: > +* ``txmode.offloads`` is set to ``0x0``, which implies: > > * Single segment is specified. > > @@ -252,7 +252,7 @@ The corresponding callbacks are: > Example of using the vector version of the virtio poll mode driver in > ``testpmd``:: > > - testpmd -l 0-2 -n 4 -- -i --txqflags=0xF01 --rxq=1 --txq=1 --nb-cores=1 > + testpmd -l 0-2 -n 4 -- -i --tx-offloads=0x0 --rxq=1 --txq=1 --nb-cores=1 > > > Interrupt mode > Acked-by: Maxime Coquelin Thanks for handling the change! Maxime