From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD
	driver
Date: Tue, 02 Apr 2019 20:19:06 +0100
Message-ID: <d2bf5816f98d715ff6e0575930f233e8b45732de.camel@debian.org>
References: <20190301080947.91086-1-xiaolong.ye@intel.com>
 <20190402154653.711-1-xiaolong.ye@intel.com>
 <20190402154653.711-2-xiaolong.ye@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: Qi Zhang <qi.z.zhang@intel.com>, Karlsson Magnus
 <magnus.karlsson@intel.com>,  Topel Bjorn <bjorn.topel@intel.com>, Maxime
 Coquelin <maxime.coquelin@redhat.com>, Bruce Richardson
 <bruce.richardson@intel.com>, Ananyev Konstantin
 <konstantin.ananyev@intel.com>,  David Marchand
 <david.marchand@redhat.com>, Andrew Rybchenko <arybchenko@solarflare.com>,
 Olivier Matz <olivier.matz@6wind.com>
To: Xiaolong Ye <xiaolong.ye@intel.com>, dev@dpdk.org, Stephen Hemminger
 <stephen@networkplumber.org>, Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com
 [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 4946858FE
 for <dev@dpdk.org>; Tue,  2 Apr 2019 21:19:08 +0200 (CEST)
Received: by mail-wr1-f67.google.com with SMTP id h4so18059595wre.7
 for <dev@dpdk.org>; Tue, 02 Apr 2019 12:19:08 -0700 (PDT)
In-Reply-To: <20190402154653.711-2-xiaolong.ye@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 2019-04-02 at 23:46 +0800, Xiaolong Ye wrote:
> diff --git a/drivers/net/af_xdp/Makefile
> b/drivers/net/af_xdp/Makefile
> new file mode 100644
> index 000000000..8343e3016
> --- /dev/null
> +++ b/drivers/net/af_xdp/Makefile
> @@ -0,0 +1,32 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2019 Intel Corporation
> +
> +include $(RTE_SDK)/mk/rte.vars.mk
> +
> +#
> +# library name
> +#
> +LIB =3D librte_pmd_af_xdp.a
> +
> +EXPORT_MAP :=3D rte_pmd_af_xdp_version.map
> +
> +LIBABIVER :=3D 1
> +
> +CFLAGS +=3D -O3
> +
> +# require kernel version >=3D v5.1-rc1
> +CFLAGS +=3D -I$(RTE_KERNELDIR)/tools/include
> +CFLAGS +=3D -I$(RTE_KERNELDIR)/tools/lib/bpf

Sorry for not noticing this before, but doesn't this require the full
kernel tree rather than just the typical headers package? Requiring the
full kernel tree to be available at build time will make this
unbuildable on distros that still use makefiles, like RHEL and SUSE. At
least on Debian and Ubuntu, the kernel headers packages distributed do
not include the full kernel tree, only the headers, so there's no
tools/lib or tools/include.

Like other dependencies, this should assume they are installed as
regular libraries, eg:

CFLAGS +=3D $(shell command -v pkg-config > /dev/null 2>&1 && pkg-config --=
cflags libbpf || echo "-I/usr/include/bpf")

> +CFLAGS +=3D $(WERROR_FLAGS)
> +LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
> +LDLIBS +=3D -lrte_ethdev -lrte_net -lrte_kvargs
> +LDLIBS +=3D -lrte_bus_vdev
> +LDLIBS +=3D -lbpf

LDLIBS +=3D $(shell command -v pkg-config > /dev/null 2>&1 && pkg-config --=
libs libbpf || echo "-lbpf")

--=20
Kind regards,
Luca Boccassi