From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Subject: Re: [PATCH] kni: fix ethtool build with kernel 4.11
Date: Wed, 3 May 2017 18:39:24 +0200
Message-ID: <d2cc241a-52d6-a332-24d0-69eb64e0f55e@6wind.com>
References: <20170503160016.31375-1-ferruh.yigit@intel.com>
Reply-To: nicolas.dichtel@6wind.com
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com
 [209.85.128.172]) by dpdk.org (Postfix) with ESMTP id 23021330D
 for <dev@dpdk.org>; Wed,  3 May 2017 18:39:19 +0200 (CEST)
Received: by mail-wr0-f172.google.com with SMTP id l9so113118672wre.1
 for <dev@dpdk.org>; Wed, 03 May 2017 09:39:19 -0700 (PDT)
In-Reply-To: <20170503160016.31375-1-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Le 03/05/2017 à 18:00, Ferruh Yigit a écrit :
> build error:
> .../build/build/lib/librte_eal/linuxapp/kni/igb_main.c:1034:10:
> error: implicit declaration of function ‘pci_enable_msix’
> [-Werror=implicit-function-declaration]
>     err = pci_enable_msix(pdev,
>               ^~~~~~~~~~~~~~~
> 
> This build error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option
> enabled.
> 
> Following Linux commit removes the pci_enable_msix()
> Linux: 4244de1c64de ("PCI: remove pci_enable_msix")
> 
> Switch to pci_enable_msix_range() for kernel > 4.8 since current Linux
> igb driver uses this function.
When looking at the kernel patches, it seems that the way to go is to use
pci_alloc_irq_vectors(), but it needs a bit more work.

Exemple :
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=da6f4cf58e40


Regards,
Nicolas