From mboxrd@z Thu Jan 1 00:00:00 1970 From: Finn Christensen Subject: Re: standardize device identification Date: Fri, 5 Jan 2018 20:32:47 +0000 Message-ID: References: <1512027330-30030-1-git-send-email-yliu@fridaylinux.org> <2746853.LkVxvJSmNi@xps> <40957417.C216t4nj8c@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , Yuanhan Liu , "Adrien Mazarguil" , Ciara Loftus , Kevin Traynor , "stephen@networkplumber.org" , "ferruh.yigit@intel.com" To: Thomas Monjalon Return-path: Received: from mail01.napatech.com (mail01.napatech.com [188.120.77.121]) by dpdk.org (Postfix) with ESMTP id AC68A8E01 for ; Fri, 5 Jan 2018 21:32:48 +0100 (CET) In-Reply-To: <40957417.C216t4nj8c@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: Thomas Monjalon [mailto:thomas@monjalon.net] >Sent: 5. januar 2018 16:34 >To: Finn Christensen >Cc: dev@dpdk.org; Yuanhan Liu ; Adrien Mazarguil >; Ciara Loftus ; Kevin >Traynor ; stephen@networkplumber.org; >ferruh.yigit@intel.com >Subject: Re: [dpdk-dev] standardize device identification > >05/01/2018 15:14, Finn Christensen: >> From: Thomas Monjalon [mailto:thomas@monjalon.net] >> >05/01/2018 12:09, Finn Christensen: >> >> From: Thomas Monjalon >> >> Which property can help to distinguish Napatech ports? >> >> Can you use class=3Deth,dev_port=3DX ? >> >> The dev_port property will use /sys/class/net/DEV/dev_port on Lin= ux. >Is it >> >> OK for you? >> >> >> >> Actually, what we were thinking of was using the mac property in >> >> the class category to distinguish our ports. >> >> For instance: >> >> -w bus=3Dpci,id=3D0000:01:00.0/class=3Deth,mac=3D00:11:22:33:44:55 >> >> or simply: >> >> -w class=3Deth,mac=3D00:11:22:33:44:55 >> > >> >The problem with the mac property is that it cannot be used for >> >white/blacklisting in DPDK because the MAC is not known before port >> >initialization. >> > >> >> Sure, that makes sense. I just for a minute thought that we could use >> that mechanism to enable individual ports at startup also. We will >> continue to use proprietary devargs passed by whiterlist to the PMD prob= e >function. >> What we needed was a way to select the individual ports, by using >> rte_eth_dev_get_port_by_name(). > >The whitelist will be replaced by this new syntax. >And yes, you can have your own driver-specific property with this syntax. That's fine. > >> >> We will not be able to support the dev_port property, that will not >> >> work for >> >us. >> >> At least not for now. > >It leads to a totally different question: >Can we discuss again how to integrate your driver in DPDK upstream? >Please explain again your situation in a new thread. Sure, I'll get back to you in a new thread. Thanks!