From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH] vhost: fix vector filling for packed ring Date: Tue, 23 Oct 2018 10:19:25 +0200 Message-ID: References: <20181023060749.25194-1-tiwei.bie@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: stable@dpdk.org To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Return-path: In-Reply-To: <20181023060749.25194-1-tiwei.bie@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Tiwei, On 10/23/2018 08:07 AM, Tiwei Bie wrote: > We should return the length of the buffers described by > the current descriptor chain after filling the buffer > vector. So we need to zero the *len first. > > Fixes: 2f3225a7d69b ("vhost: add vector filling support for packed ring") > Cc: stable@dpdk.org > > Signed-off-by: Tiwei Bie > --- > lib/librte_vhost/virtio_net.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c > index 48228f16b..4e6c35d56 100644 > --- a/lib/librte_vhost/virtio_net.c > +++ b/lib/librte_vhost/virtio_net.c > @@ -521,6 +521,7 @@ fill_vec_buf_packed(struct virtio_net *dev, struct vhost_virtqueue *vq, > return -1; > > *desc_count = 0; > + *len = 0; > > while (1) { > if (unlikely(vec_id >= BUF_VECTOR_MAX)) > Good catch, I guess I didn't felt into that bug because my test-cases were too simple (single descriptor were enough). Reviewed-by: Maxime Coquelin Thanks! Maxime