From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Subject: Re: [PATCH] examples/l3fwd: force CRC stripping for i40evf Date: Wed, 9 Nov 2016 10:39:06 +0100 Message-ID: References: <20161109082341.19825-1-bjorn.topel@intel.com> <1500406.Wuc0qeu8Dv@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org, qian.q.xu@intel.com, lei.a.yao@intel.com, jingjing.wu@intel.com To: Thomas Monjalon Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id C3C9CFFA for ; Wed, 9 Nov 2016 10:39:11 +0100 (CET) In-Reply-To: <1500406.Wuc0qeu8Dv@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Thanks for raising the issue. It is completely defeating the generic > ethdev API. We must not have different behaviours depending of the > driver. Why it cannot be fixed in the driver? I should probably refer to the thread, where the concern was raised: http://dpdk.org/ml/archives/dev/2016-July/044555.html So, the issue is that i40evf *only support* CRC stripping for some setups (i40e Linux driver for PF, i40evf DPDK driver VF). The l3fwd application disables CRC stripping for all ports, which leads to i40evf_dev_configure() failure -- which from my POV is correct. Mis-configuring a port shouldn't be allowed. I'm open to suggestions here. What would be a better way to solve this? Maybe just adding a command-line option to the l3fwd application is a better way around? Björn