From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53B5FC4743C for ; Wed, 23 Jun 2021 09:10:02 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id CFA35611AD for ; Wed, 23 Jun 2021 09:10:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFA35611AD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF9234003F; Wed, 23 Jun 2021 11:10:00 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 37ABB4003E for ; Wed, 23 Jun 2021 11:09:59 +0200 (CEST) IronPort-SDR: ghku/xI7yM828t+v1FLq5+phJrpn0sGLeABYKWBEB2/9Kn/B3e1T9sj4rSGxZf6ltJ5hYc6OWY 6sv5TBVX5WQQ== X-IronPort-AV: E=McAfee;i="6200,9189,10023"; a="204218222" X-IronPort-AV: E=Sophos;i="5.83,293,1616482800"; d="scan'208,217";a="204218222" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2021 02:09:58 -0700 IronPort-SDR: dyLRYO56vUe/LKBIk/x8MWvyXdsTVp7ve2rH3vgzV8zsITXlek+knW6bnrnZ9JrQo2wCNlU9TR KKVDkpsEDTOA== X-IronPort-AV: E=Sophos;i="5.83,293,1616482800"; d="scan'208,217";a="556081672" Received: from amandee1-mobl.gar.corp.intel.com (HELO [10.213.68.216]) ([10.213.68.216]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2021 02:09:56 -0700 To: Viacheslav Ovsiienko , dev@dpdk.org References: <20210619154012.27295-1-viacheslavo@nvidia.com> From: "Singh, Aman Deep" Message-ID: Date: Wed, 23 Jun 2021 14:39:51 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210619154012.27295-1-viacheslavo@nvidia.com> Content-Language: en-GB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads for the newly attached port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Acked-by: Aman Deep Singh On 6/19/2021 9:10 PM, Viacheslav Ovsiienko wrote: > For the newly attached ports (with "port attach" command) the > default offloads settings, configured from application command > line, were not applied, causing port start failure following > the attach. For example, if scattering offload was configured > in command line and rxpkts was configured for multiple segments, > the newly attached port start was failed due to missing scattering > offload enable in the new port settings. The missing code to apply > the offloads to the new device and its queues is added. > > Cc: stable@dpdk.org > Fixes: c9cce42876f5 ("ethdev: remove deprecated attach/detach functions") > > Signed-off-by: Viacheslav Ovsiienko > --- > >