Re: [PATCH v5 08/27] net/i40e: remove global pattern variable

Medvedkin, Vladimir
2026-02-17T17:15:45Z

Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>

On 2/17/2026 12:13 PM, Anatoly Burakov wrote:
> When parsing flow patterns, current code cleans up the pattern list by
> removing void flow items, and copies the patterns into an array. That
> array, when dealing with under 32 flow items, is allocated on the stack,
> but when the pattern is big enough, a new list is dynamically allocated.
> This allocated list is a global variable, and is allocated using
> rte_zmalloc call which seems like overkill for this use case.
>
> Remove the global variable, and replace the split behavior with
> unconditional allocation.
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> drivers/net/intel/i40e/i40e_flow.c | 29 +++++++++--------------------
> 1 file changed, 9 insertions(+), 20 deletions(-)
>
<snip>

--
Regards,
Vladimir