From mboxrd@z Thu Jan  1 00:00:00 1970
From: Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [PATCH 2/6] crypto/mvsam: update hash digest sizes
Date: Mon, 17 Sep 2018 19:24:41 +0530
Message-ID: <d53bff1e-c79d-3ca8-1428-1f3fb2dce30d@nxp.com>
References: <1535118895-6505-1-git-send-email-tdu@semihalf.com>
 <1535118895-6505-3-git-send-email-tdu@semihalf.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: nsamsono@marvell.com, mw@semihalf.com, Szymon Sliwa <szs@semihalf.com>
To: Tomasz Duszynski <tdu@semihalf.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-eopbgr40042.outbound.protection.outlook.com [40.107.4.42])
 by dpdk.org (Postfix) with ESMTP id 4CA2A1ADD3
 for <dev@dpdk.org>; Mon, 17 Sep 2018 15:54:56 +0200 (CEST)
In-Reply-To: <1535118895-6505-3-git-send-email-tdu@semihalf.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Tomasz,

Is this patch a fix which needs to be applied for stable as well or you have
added some changes in the code which can support this.

-Akhil

On 8/24/2018 7:24 PM, Tomasz Duszynski wrote:
> From: Szymon Sliwa <szs@semihalf.com>
>
> Update hash digest sizes to match hardware capabilities.
>
> Signed-off-by: Szymon Sliwa <szs@semihalf.com>
> Reviewed-by: Yelena Krivosheev <yelena@marvell.com>
> Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
> ---
>   drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 46 ++++++++++++++++-----------------
>   1 file changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> index c045562..e2cfc07 100644
> --- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> +++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> @@ -30,9 +30,9 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 1
>   				},
>   				.digest_size = {
> -					.min = 16,
> +					.min = 12,
>   					.max = 16,
> -					.increment = 0
> +					.increment = 4
>   				},
>   			}, }
>   		}, }
> @@ -50,9 +50,9 @@ static const struct rte_cryptodev_capabilities
>   						.increment = 0
>   					},
>   					.digest_size = {
> -						.min = 16,
> +						.min = 12,
>   						.max = 16,
> -						.increment = 0
> +						.increment = 4
>   					},
>   				}, }
>   			}, }
> @@ -70,9 +70,9 @@ static const struct rte_cryptodev_capabilities
>   						.increment = 1
>   					},
>   					.digest_size = {
> -						.min = 20,
> +						.min = 12,
>   						.max = 20,
> -						.increment = 0
> +						.increment = 4
>   					},
>   				}, }
>   			}, }
> @@ -90,9 +90,9 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 0
>   				},
>   				.digest_size = {
> -					.min = 20,
> +					.min = 12,
>   					.max = 20,
> -					.increment = 0
> +					.increment = 4
>   				},
>   			}, }
>   		}, }
> @@ -110,9 +110,9 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 0
>   				},
>   				.digest_size = {
> -					.min = 28,
> +					.min = 12,
>   					.max = 28,
> -					.increment = 0
> +					.increment = 4
>   				},
>   			}, }
>   		}, }
> @@ -130,9 +130,9 @@ static const struct rte_cryptodev_capabilities
>   						.increment = 1
>   					},
>   					.digest_size = {
> -						.min = 32,
> +						.min = 12,
>   						.max = 32,
> -						.increment = 0
> +						.increment = 4
>   					},
>   				}, }
>   			}, }
> @@ -150,9 +150,9 @@ static const struct rte_cryptodev_capabilities
>   						.increment = 0
>   					},
>   					.digest_size = {
> -						.min = 32,
> +						.min = 12,
>   						.max = 32,
> -						.increment = 0
> +						.increment = 4
>   					},
>   				}, }
>   			}, }
> @@ -170,9 +170,9 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 1
>   				},
>   				.digest_size = {
> -					.min = 48,
> +					.min = 12,
>   					.max = 48,
> -					.increment = 0
> +					.increment = 4
>   				},
>   			}, }
>   		}, }
> @@ -190,9 +190,9 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 0
>   				},
>   				.digest_size = {
> -					.min = 48,
> +					.min = 12,
>   					.max = 48,
> -					.increment = 0
> +					.increment = 4
>   				},
>   			}, }
>   		}, }
> @@ -210,9 +210,9 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 1
>   				},
>   				.digest_size = {
> -					.min = 64,
> -					.max = 64,
> -					.increment = 0
> +					.min = 12,
> +					.max = 48,
> +					.increment = 4
>   				},
>   			}, }
>   		}, }
> @@ -230,8 +230,8 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 0
>   				},
>   				.digest_size = {
> -					.min = 64,
> -					.max = 64,
> +					.min = 12,
> +					.max = 48,
>   					.increment = 0
>   				},
>   			}, }