From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] net/tap: remove queue specific offload
	support
Date: Wed, 18 Apr 2018 11:55:09 +0100
Message-ID: <d5610f79-2bac-e364-daa4-6a3c38c4f40d@intel.com>
References: <20180322182843.105732-1-ferruh.yigit@intel.com>
 <2913888.DGWfva7bOG@xps> <e2cea389-14ac-2aeb-0426-d20b692e2ebe@intel.com>
 <33d0cd29-855e-58dd-683d-e540a7978515@intel.com>
 <HE1PR0501MB23147AC7B77F2ABF1E3D9C23D1B60@HE1PR0501MB2314.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, Shahaf Shuler <shahafs@mellanox.com>,
 Olga Shern <olgas@mellanox.com>
To: Ophir Munk <ophirmu@mellanox.com>, Thomas Monjalon <thomas@monjalon.net>,
 Pascal Mazon <pascal.mazon@6wind.com>,
 Mordechay Haimovsky <motih@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id AABAA8D95
 for <dev@dpdk.org>; Wed, 18 Apr 2018 12:55:14 +0200 (CEST)
In-Reply-To: <HE1PR0501MB23147AC7B77F2ABF1E3D9C23D1B60@HE1PR0501MB2314.eurprd05.prod.outlook.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/18/2018 10:40 AM, Ophir Munk wrote:
> Hi Ferruh,
> Sorry for the delayed response.
> 
> I would like to verify the correctness of this patch by running several internal tests.
> Is a reply by Monday OK with you?

Monday can be late to include patch into rc1, any chance to do earlier?

> 
> Regards,
> Ophir
> 
>> -----Original Message-----
>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>> Sent: Wednesday, April 18, 2018 11:59 AM
>> To: Thomas Monjalon <thomas@monjalon.net>; Pascal Mazon
>> <pascal.mazon@6wind.com>; Mordechay Haimovsky
>> <motih@mellanox.com>; Ophir Munk <ophirmu@mellanox.com>
>> Cc: dev@dpdk.org; Shahaf Shuler <shahafs@mellanox.com>; Olga Shern
>> <olgas@mellanox.com>
>> Subject: Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload
>> support
>>
>> On 4/12/2018 5:23 PM, Ferruh Yigit wrote:
>>> On 4/5/2018 6:49 PM, Thomas Monjalon wrote:
>>>> Pascal, Moti, Ophir,
>>>> please comment.
>>>
>>> Hi Moti,
>>>
>>> Any comment? This has been asked many times now.
>>
>> Hi Moti, Ophir,
>>
>> You have not responded why queue specific offload added in other thread.
>> And you are not responding to this patch...
>>
>> Hi Pascal,
>>
>> If you also have no objection, this patch is going in.
>>
>> Thanks,
>> ferruh
>>
>>
>>>
>>>>
>>>> 22/03/2018 19:28, Ferruh Yigit:
>>>>> It is not clear if tap PMD supports queue specific offloads,
>>>>> removing the related code.
>>>>>
>>>>> Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API")
>>>>> Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API")
>>>>> Cc: motih@mellanox.com
>>>>>
>>>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>>>
>>>>
>>>>
>>>
>