From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v4 03/10] vhost: provide helpers for virtio ring relay Date: Sun, 16 Dec 2018 10:10:38 +0100 Message-ID: References: <20181213100910.13087-2-xiao.w.wang@intel.com> <20181214211612.167681-1-xiao.w.wang@intel.com> <20181214211612.167681-4-xiao.w.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: alejandro.lucero@netronome.com, dev@dpdk.org, zhihong.wang@intel.com, xiaolong.ye@intel.com To: Xiao Wang , tiwei.bie@intel.com Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 89AFA1B923 for ; Sun, 16 Dec 2018 10:10:44 +0100 (CET) In-Reply-To: <20181214211612.167681-4-xiao.w.wang@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/14/18 10:16 PM, Xiao Wang wrote: > This patch provides two helpers for vdpa device driver to perform a > relay between the guest virtio ring and a mediate virtio ring. s/mediate/mediated/ ? I'm not 100% sure, but if it is mediated, please change everywhere else in the patch. > > The available ring relay will synchronize the available entries, and > helps to do desc validity checking. s/helps/help/ > > The used ring relay will synchronize the used entries from mediate ring > to guest ring, and helps to do dirty page logging for live migration. s/helps/help/ > > The next patch will leverage these two helpers. > > Signed-off-by: Xiao Wang > --- > lib/librte_vhost/rte_vdpa.h | 39 +++++++ > lib/librte_vhost/rte_vhost_version.map | 2 + > lib/librte_vhost/vdpa.c | 194 +++++++++++++++++++++++++++++++++ > lib/librte_vhost/vhost.h | 40 +++++++ > lib/librte_vhost/virtio_net.c | 39 ------- > 5 files changed, 275 insertions(+), 39 deletions(-) > Appart from that: Reviewed-by: Maxime Coquelin Thanks, Maxime