public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
* [PATCH v1 1/1] net/iavf: fix incorrect struct in status get
@ 2026-02-20 10:01 Anatoly Burakov
  2026-02-20 10:14 ` Radu Nicolau
  0 siblings, 1 reply; 3+ messages in thread
From: Anatoly Burakov @ 2026-02-20 10:01 UTC (permalink / raw)
  To: dev, Vladimir Medvedkin, Qi Zhang, Radu Nicolau

Current code for getting crypto status is using sizeof() of cap struct
instead of status structure. This is not a big problem because cap struct
is a lot bigger, but the code is misleading. Fix it to use the correct
struct.

Fixes: 3940cd9b8cb3 ("net/iavf: fix device initialization without inline crypto")
Cc: radu.nicolau@intel.com
Cc: stable@dpdk.org

Reported-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 drivers/net/intel/iavf/iavf_ipsec_crypto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/intel/iavf/iavf_ipsec_crypto.c b/drivers/net/intel/iavf/iavf_ipsec_crypto.c
index 6d41b1744e..ab41b1973e 100644
--- a/drivers/net/intel/iavf/iavf_ipsec_crypto.c
+++ b/drivers/net/intel/iavf/iavf_ipsec_crypto.c
@@ -1600,7 +1600,7 @@ iavf_ipsec_crypto_status_get(struct iavf_adapter *adapter,
 	}
 
 	response_len = sizeof(struct inline_ipsec_msg) +
-			sizeof(struct virtchnl_ipsec_cap);
+			sizeof(struct virtchnl_ipsec_status);
 	response = rte_malloc("iavf-device-status-response",
 			response_len, 0);
 	if (response == NULL) {
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] net/iavf: fix incorrect struct in status get
  2026-02-20 10:01 [PATCH v1 1/1] net/iavf: fix incorrect struct in status get Anatoly Burakov
@ 2026-02-20 10:14 ` Radu Nicolau
  2026-02-20 10:39   ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: Radu Nicolau @ 2026-02-20 10:14 UTC (permalink / raw)
  To: Anatoly Burakov, dev, Vladimir Medvedkin, Qi Zhang

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]


On 20-Feb-26 10:01 AM, Anatoly Burakov wrote:
> Current code for getting crypto status is using sizeof() of cap struct
> instead of status structure. This is not a big problem because cap struct
> is a lot bigger, but the code is misleading. Fix it to use the correct
> struct.
>
> Fixes: 3940cd9b8cb3 ("net/iavf: fix device initialization without inline crypto")
> Cc:radu.nicolau@intel.com
> Cc:stable@dpdk.org
>
> Reported-by: Stephen Hemminger<stephen@networkplumber.org>
> Signed-off-by: Anatoly Burakov<anatoly.burakov@intel.com>
> ---

Acked-by: Radu Nicolau <radu.nicolau@intel.com>

[-- Attachment #2: Type: text/html, Size: 36842 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] net/iavf: fix incorrect struct in status get
  2026-02-20 10:14 ` Radu Nicolau
@ 2026-02-20 10:39   ` Bruce Richardson
  0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2026-02-20 10:39 UTC (permalink / raw)
  To: Radu Nicolau; +Cc: Anatoly Burakov, dev, Vladimir Medvedkin, Qi Zhang

On Fri, Feb 20, 2026 at 10:14:55AM +0000, Radu Nicolau wrote:
>    On 20-Feb-26 10:01 AM, Anatoly Burakov wrote:
> 
> Current code for getting crypto status is using sizeof() of cap struct
> instead of status structure. This is not a big problem because cap struct
> is a lot bigger, but the code is misleading. Fix it to use the correct
> struct.
> 
> Fixes: 3940cd9b8cb3 ("net/iavf: fix device initialization without inline crypto"
> )
> Cc: [1]radu.nicolau@intel.com
> Cc: [2]stable@dpdk.org
> 
> Reported-by: Stephen Hemminger [3]<stephen@networkplumber.org>
> Signed-off-by: Anatoly Burakov [4]<anatoly.burakov@intel.com>
> ---
> 
>    Acked-by: Radu Nicolau <[5]radu.nicolau@intel.com>
> 
Applied to dpdk-next-net-intel.

Thanks,
/Bruce

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-20 10:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-20 10:01 [PATCH v1 1/1] net/iavf: fix incorrect struct in status get Anatoly Burakov
2026-02-20 10:14 ` Radu Nicolau
2026-02-20 10:39   ` Bruce Richardson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox