From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2 22/32] app/testpmd: use multicast promiscuous mode on i40e Date: Wed, 7 Dec 2016 15:01:45 +0000 Message-ID: References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-23-git-send-email-wenzhuo.lu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Wenzhuo Lu , dev@dpdk.org Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A50D32B8C for ; Wed, 7 Dec 2016 16:02:33 +0100 (CET) In-Reply-To: <1481081535-37448-23-git-send-email-wenzhuo.lu@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > Add testpmd CLI to set VF multicast promiscuous mode on i40e. > > Signed-off-by: Wenzhuo Lu > --- > app/test-pmd/cmdline.c | 86 +++++++++++++++++++++++++++++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 +++ > 2 files changed, 94 insertions(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index d39712e..7e7a016 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -407,6 +407,9 @@ static void cmd_help_long_parsed(void *parsed_result, > #ifdef RTE_LIBRTE_I40E_PMD > "set vf unicast-promisc (port_id) (vf_id) (on|off)\n" > " Set unicast promiscuous mode for a VF from the PF.\n\n" > + > + "set vf multicast-promisc (port_id) (vf_id) (on|off)\n" > + " Set multicast promiscuous mode for a VF from the PF.\n\n" Why not "allmulti" instead of multicast-promisc? Also same comments as previous patch for help_str and documentation. <...>