From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jia He Subject: Re: [PATCH V7 2/3] ring: introduce new header file to include common functions Date: Tue, 16 Jan 2018 10:06:23 +0800 Message-ID: References: <1511748024-7245-1-git-send-email-hejianet@gmail.com> <1512352212-7191-1-git-send-email-hejianet@gmail.com> <1512352212-7191-3-git-send-email-hejianet@gmail.com> <2019957.4IyS66Gqvj@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Jerin Jacob , Jianbo Liu , Jan Viktorin , Olivier Matz , konstantin.ananyev@intel.com, hemant.agrawal@nxp.com, Jia He To: Thomas Monjalon Return-path: Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66]) by dpdk.org (Postfix) with ESMTP id 9079571B5 for ; Tue, 16 Jan 2018 03:06:34 +0100 (CET) Received: by mail-pg0-f66.google.com with SMTP id k68so1118840pga.3 for ; Mon, 15 Jan 2018 18:06:34 -0800 (PST) In-Reply-To: <2019957.4IyS66Gqvj@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/13/2018 1:09 AM, Thomas Monjalon Wrote: > 04/12/2017 02:50, Jia He: >> move the common part of rte_ring.h into rte_ring_generic.h. >> move the memory barrier part into update_tail(). >> >> no functional changes here. > [...] >> --- /dev/null >> +++ b/lib/librte_ring/rte_ring_generic.h >> @@ -0,0 +1,195 @@ >> +/*- >> + * BSD LICENSE >> + * >> + * Copyright(c) 2017 hxt-semitech. All rights reserved. > As you are moving existing code, I think you should keep > the original copyright. Ok, thanks for the comments -- Cheers, Jia