From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 02/61] send FW version driver state to MFW
Date: Fri, 3 Mar 2017 10:26:10 +0000
Message-ID: <d5f9e02c-a40f-ea4d-562e-b43f43fb9c70@intel.com>
References: <1488182237-10247-1-git-send-email-rasesh.mody@cavium.com>
 <1488182237-10247-3-git-send-email-rasesh.mody@cavium.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: Dept-EngDPDKDev@cavium.com
To: Rasesh Mody <rasesh.mody@cavium.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 96AEA2B9D
 for <dev@dpdk.org>; Fri,  3 Mar 2017 11:26:15 +0100 (CET)
In-Reply-To: <1488182237-10247-3-git-send-email-rasesh.mody@cavium.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2/27/2017 7:56 AM, Rasesh Mody wrote:
> Add support to send FW version and driver state to Management FW.
> 
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>

<...>

> -	return ECORE_SUCCESS;
> +	if (IS_PF(p_dev)) {
> +		p_hwfn = ECORE_LEADING_HWFN(p_dev);
> +		drv_mb_param = (FW_MAJOR_VERSION << 24) |
> +			       (FW_MINOR_VERSION << 16) |
> +			       (FW_REVISION_VERSION << 8) |
> +			       (FW_ENGINEERING_VERSION);
> +		rc = ecore_mcp_cmd(p_hwfn, p_hwfn->p_main_ptt,
> +				   DRV_MSG_CODE_OV_UPDATE_STORM_FW_VER,
> +				   drv_mb_param, &load_code, &param);
> +		if (rc != ECORE_SUCCESS) {
> +			DP_ERR(p_hwfn, "Failed to send firmware version\n");
> +			return rc;
> +		}
> +
> +		rc = ecore_mcp_ov_update_driver_state(p_hwfn,
> +						      p_hwfn->p_main_ptt,
> +						ECORE_OV_DRIVER_STATE_DISABLED);

Is this something that effects end user, the application that uses this PMD?

> +	}
> +
> +	return rc;
>  }
>  

<...>