From mboxrd@z Thu Jan  1 00:00:00 1970
From: Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [PATCH 6/6] app/crypto-perf: use single mempool
Date: Wed, 30 Aug 2017 14:00:46 +0530
Message-ID: <d629f6be-c9dd-9dd6-1a18-92cd50968aeb@nxp.com>
References: <20170818080520.43088-1-pablo.de.lara.guarch@intel.com>
 <20170818080520.43088-7-pablo.de.lara.guarch@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>,
 <declan.doherty@intel.com>, <fiona.trahe@intel.com>,
 <deepak.k.jain@intel.com>, <john.griffin@intel.com>,
 <jerin.jacob@caviumnetworks.com>, <hemant.agrawal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam03on0050.outbound.protection.outlook.com [104.47.40.50])
 by dpdk.org (Postfix) with ESMTP id D76E429D6
 for <dev@dpdk.org>; Wed, 30 Aug 2017 10:30:57 +0200 (CEST)
In-Reply-To: <20170818080520.43088-7-pablo.de.lara.guarch@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Pablo,
On 8/18/2017 1:35 PM, Pablo de Lara wrote:
> In order to improve memory utilization, a single mempool
> is created, containing the crypto operation and mbufs
> (one if operation is in-place, two if out-of-place).
> This way, a single object is allocated and freed
> per operation, reducing the amount of memory in cache,
> which improves scalability.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>   app/test-crypto-perf/cperf_ops.c             |  96 ++++++--
>   app/test-crypto-perf/cperf_ops.h             |   2 +-
>   app/test-crypto-perf/cperf_test_latency.c    | 350 ++++++++++++--------------
>   app/test-crypto-perf/cperf_test_throughput.c | 347 ++++++++++++--------------
>   app/test-crypto-perf/cperf_test_verify.c     | 356 ++++++++++++---------------
>   5 files changed, 553 insertions(+), 598 deletions(-)
> 
NACK.
This patch replaces rte_pktmbuf_pool_create with the rte_mempool_create 
for mbufs, which is not a preferred way to allocate memory for pktmbuf.

Any example/test application in DPDK should not be using this, as this 
kind of usages will  not be compatible for all dpdk drivers in general.

This kind of usages of rte_mempool_create will not work for any devices 
using hw offloaded memory pools for pktmbuf.
one such example is dpaa2.

-Akhil