From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v6 1/4] test: add ring pmd based packet rx/tx
 for UT
Date: Thu, 26 Jul 2018 10:59:00 +0100
Message-ID: <d640a2ab-b7ff-bb57-2fa4-c2d53bf9b24a@intel.com>
References: <1532429671-1606-1-git-send-email-naga.sureshx.somarowthu@intel.com>
 <1532538360-8773-1-git-send-email-naga.sureshx.somarowthu@intel.com>
 <1532538360-8773-2-git-send-email-naga.sureshx.somarowthu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: remy.horton@intel.com, reshma.pattan@intel.com
To: Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id F1B5637B4
 for <dev@dpdk.org>; Thu, 26 Jul 2018 11:59:03 +0200 (CEST)
In-Reply-To: <1532538360-8773-2-git-send-email-naga.sureshx.somarowthu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 25-Jul-18 6:05 PM, Naga Suresh Somarowthu wrote:
> Added ring pmd based packet rx/tx helper functions
> for verifying Latency, Bitrate and pdump lib UTs.
> 
> Signed-off-by: Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>
> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
> ---

<snip>

> +	ret = test_get_mempool(mp, poolname);
> +	if (ret < 0)
> +		return -1;
> +	if (rte_pktmbuf_alloc_bulk(*mp, pbuf, NUM_PACKETS) != 0) {
> +		printf("%s() line %u: rte_pktmbuf_alloc_bulk failed", __func__,
> +		       __LINE__);
> +		return -1;
> +	}
> +	return 0;
> +}
> +
> +/* sample test to deallocate the allocated buffers */
> +void
> +test_put_mbuf_to_pool(struct rte_mempool *mp, struct rte_mbuf **pbuf)
> +{
> +	int itr = 0;
> +
> +	for (itr = 0; itr < NUM_PACKETS; itr++)
> +		rte_pktmbuf_free(pbuf[itr]);
> +	rte_mempool_free(mp);
> +}

The name and description of the above function is a little misleading. 
It says it will deallocate buffers, but nowhere does it say that it will 
also deallocate the mempool. Is that intentional?

Other than that,

Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly