From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v2] add mtu set in virtio Date: Tue, 30 Aug 2016 09:57:39 +0200 Message-ID: References: <20160829230240.20164-1-sodey@sonusnet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: souvikdey33 , stephen@networkplumber.org, huawei.xie@intel.com, yuanhan.liu@linux.intel.com Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 9565C29CF for ; Tue, 30 Aug 2016 09:57:44 +0200 (CEST) In-Reply-To: <20160829230240.20164-1-sodey@sonusnet.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Souvik, On 08/30/2016 01:02 AM, souvikdey33 wrote: > Signed-off-by: Souvik Dey > > Fixes: 1fb8e8896ca8 ("Signed-off-by: Souvik Dey ") > Reviewed-by: Stephen Hemminger > > Virtio interfaces should also support setting of mtu, as in case of cloud > it is expected to have the consistent mtu across the infrastructure that > the dhcp server sends and not hardcoded to 1500(default). > --- > drivers/net/virtio/virtio_ethdev.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) FYI, there are some on-going changes in the VIRTIO specification so that the VHOST interface exposes its MTU to its VIRTIO peer. It may also be used as an alternative of what you patch achieves. I am working on its implementation in Qemu/DPDK, our goal being to reduce performance drops for small packets with Rx mergeable buffers feature enabled. Regards, Maxime