From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh Subject: Re: [RFC v2 01/17] mempool: fix phys contig check if populate default skipped Date: Thu, 1 Feb 2018 10:35:45 +0530 Message-ID: References: <1511539591-20966-1-git-send-email-arybchenko@solarflare.com> <1516713372-10572-1-git-send-email-arybchenko@solarflare.com> <1516713372-10572-2-git-send-email-arybchenko@solarflare.com> <20180131164504.cnfgfwo2x3ftxnaj@platinum> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, stable@dpdk.org, jerin.jacob@caviumnetworks.com To: Olivier Matz , Andrew Rybchenko Return-path: In-Reply-To: <20180131164504.cnfgfwo2x3ftxnaj@platinum> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wednesday 31 January 2018 10:15 PM, Olivier Matz wrote: > On Tue, Jan 23, 2018 at 01:15:56PM +0000, Andrew Rybchenko wrote: >> There is not specified dependency between rte_mempool_populate_default() >> and rte_mempool_populate_iova(). So, the second should not rely on the >> fact that the first adds capability flags to the mempool flags. >> >> Fixes: 65cf769f5e6a ("mempool: detect physical contiguous objects") >> Cc: stable@dpdk.org >> >> Signed-off-by: Andrew Rybchenko > Looks good to me. I agree it's strange that the mp->flags are > updated with capabilities only in rte_mempool_populate_default(). > I see that this behavior is removed later in the patchset since the > get_capa() is removed! > > However maybe this single patch could go in 18.02. > +Santosh +Jerin since it's mostly about Octeon. rte_mempool_xmem_size should return correct size if MEMPOOL_F_CAPA_BLK_ALIGNED_OBJECTS flag is set in 'mp->flags'. Thats why _ops_get_capabilities() called in _populate_default() but not at _populate_iova(). I think, this 'alone' patch may break octeontx mempool.