From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E65AC2D0A8 for ; Wed, 23 Sep 2020 16:45:07 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 1DF4F20791 for ; Wed, 23 Sep 2020 16:45:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DF4F20791 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 27B591C2AE; Wed, 23 Sep 2020 18:45:06 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 457C01C205 for ; Wed, 23 Sep 2020 18:45:05 +0200 (CEST) IronPort-SDR: V3h675ECxFCBYeFuluaspIFysIRS7+XGK/pdfwfL4SQG6ISYRJPQtCIwXlVkNSYueZGc01kbSp 6zAG/2mYermg== X-IronPort-AV: E=McAfee;i="6000,8403,9753"; a="245773881" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="245773881" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 09:45:04 -0700 IronPort-SDR: H47v/IRvX0sRqkkuC2u95gDO70Mx2lNDnwqfqOdg1mPFWHhb7g43Q4hhvqy1Bk2Hl3kwkAkdx8 jmz40J04B9ig== X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="305448125" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.218.147]) ([10.213.218.147]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 09:45:01 -0700 To: Thomas Monjalon , dev@dpdk.org Cc: arybchenko@solarflare.com, Rosen Xu , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Heinrich Kuhn , Gagandeep Singh , Akhil Goyal , Martin Spinler , Anatoly Burakov References: <20200913220711.3768597-1-thomas@monjalon.net> <20200913220711.3768597-18-thomas@monjalon.net> From: Ferruh Yigit Message-ID: Date: Wed, 23 Sep 2020 17:45:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200913220711.3768597-18-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 17/20] drivers/net: accept removing device without any port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/13/2020 11:07 PM, Thomas Monjalon wrote: > The ports can be closed (i.e. completely released) > before removing the whole device. > Such case was wrongly considered an error by some drivers. > > If the device supports only one port, there is nothing much > to free after the port is closed. > > Signed-off-by: Thomas Monjalon > --- > drivers/net/ipn3ke/ipn3ke_ethdev.c | 6 ++---- > drivers/net/kni/rte_eth_kni.c | 16 +++++++--------- > drivers/net/netvsc/hn_ethdev.c | 2 +- > drivers/net/nfp/nfp_net.c | 2 ++ > drivers/net/pfe/pfe_ethdev.c | 6 ++---- > drivers/net/szedata2/rte_eth_szedata2.c | 6 ++---- > 6 files changed, 16 insertions(+), 22 deletions(-) For net/kni, Reviewed-by: Ferruh Yigit