From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] drivers/net: document missing speed
 capabilities feature
Date: Mon, 15 May 2017 09:40:20 +0100
Message-ID: <d6b460e1-e9d3-831d-7a06-42cedc5cf50e@intel.com>
References: <20170510131053.75843-1-ferruh.yigit@intel.com>
 <16254100.QC6ztoDaX8@xps> <f4aa5d75-6a50-d39d-b367-98e5e924f4dc@intel.com>
 <17406199.hqjMraK9H2@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Shepard Siegel <shepard.siegel@atomicrules.com>,
 Ed Czeck <ed.czeck@atomicrules.com>,
 John Miller <john.miller@atomicrules.com>,
 John McNamara <john.mcnamara@intel.com>,
 Harish Patil <harish.patil@cavium.com>, Rasesh Mody
 <rasesh.mody@cavium.com>, Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk <mk@semihalf.com>,
 Guy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>,
 Jing Chen <jing.d.chen@intel.com>, Helin Zhang <helin.zhang@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>, Matej Vido <vido@cesnet.cz>,
 Pascal Mazon <pascal.mazon@6w
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 23E113B5
 for <dev@dpdk.org>; Mon, 15 May 2017 10:40:28 +0200 (CEST)
In-Reply-To: <17406199.hqjMraK9H2@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/12/2017 4:48 PM, Thomas Monjalon wrote:
> 12/05/2017 12:49, Ferruh Yigit:
>> On 5/10/2017 2:51 PM, Thomas Monjalon wrote:
>>> 10/05/2017 15:10, Ferruh Yigit:
>>>> --- a/doc/guides/nics/features/bnx2x.ini
>>>> +++ b/doc/guides/nics/features/bnx2x.ini
>>>> @@ -4,6 +4,7 @@
>>>>  ; Refer to default.ini for the full list of available PMD features.
>>>>  ;
>>>>  [Features]
>>>> +Speed capabilities   = Y
>>>
>>> We should validate this feature only if the driver advertise the
>>> right speeds for the device.
>>
>> Hi Thomas,
>>
>> Can you please clarify more, what is expected implementation in PMD?
> 
> It is expected to advertise only the speeds that the device is
> capable to offer.
> 
>> And perhaps a good and a bad sample can be helpful.
> 
> Good example:
> drivers/net/i40e/i40e_ethdev.c
>     if (I40E_PHY_TYPE_SUPPORT_40G(hw->phy.phy_types))
>         /* For XL710 */
>         dev_info->speed_capa = ETH_LINK_SPEED_40G;
>     else if (I40E_PHY_TYPE_SUPPORT_25G(hw->phy.phy_types))
>         /* For XXV710 */
>         dev_info->speed_capa = ETH_LINK_SPEED_25G;
>     else
>         /* For X710 */
>         dev_info->speed_capa = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_10G;
> 
> Bad example:
> drivers/net/bnx2x/bnx2x_ethdev.c
>     dev_info->speed_capa = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_20G;
> Looking at qlogic.com, only some 57840 adapters are capable of 20G.

OK, I will update the patch according.

Does it make sense to mark PMDs that report speed_capabilities, but
without checking actual hw, as partial "P", to differentiate them from
the ones that doesn't report at all, also this may help to PMD
maintainers about what to fix.

Thanks,
ferruh