From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] doc: address the offload API changes for
	virtio guide
Date: Fri, 25 May 2018 10:09:08 +0100
Message-ID: <d6bd789d-780f-6074-d644-403e6251ce1e@intel.com>
References: <20180525061748.16184-1-tiwei.bie@intel.com>
 <5534310e-3539-87d8-95c9-befc1c4c9b4f@intel.com>
 <20180525082736.GA4935@debian> <20180525085454.GA15338@debian>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: maxime.coquelin@redhat.com, john.mcnamara@intel.com,
 marko.kovacevic@intel.com, dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id B1A762BF2
 for <dev@dpdk.org>; Fri, 25 May 2018 11:09:11 +0200 (CEST)
In-Reply-To: <20180525085454.GA15338@debian>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/25/2018 9:54 AM, Tiwei Bie wrote:
> On Fri, May 25, 2018 at 04:27:36PM +0800, Tiwei Bie wrote:
>> On Fri, May 25, 2018 at 09:20:08AM +0100, Ferruh Yigit wrote:
>>> On 5/25/2018 7:17 AM, Tiwei Bie wrote:
>>>> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
>>>
>>> <...>
>>>
>>>> @@ -252,7 +252,7 @@ The corresponding callbacks are:
>>>>  Example of using the vector version of the virtio poll mode driver in
>>>>  ``testpmd``::
>>>>  
>>>> -   testpmd -l 0-2 -n 4 -- -i --txqflags=0xF01 --rxq=1 --txq=1 --nb-cores=1
>>>> +   testpmd -l 0-2 -n 4 -- -i --tx-offloads=0x0 --rxq=1 --txq=1 --nb-cores=1
>>>
>>> Thanks, I missed this one, there are a few occurrence of "--txqflags" [1].
>>>
>>> Tiwei would you mind sending another patch for those?
>>> In below context "--txqflags" is not really focus, I think we can just remove it
>>> without replacing with "--tx-offloads"
>>
>> No problem. I will do it now. :)
>>
>> Best regards,
>> Tiwei Bie
>>
>>>
>>> Thanks,
>>> ferruh
>>>
>>>
>>> [1]
>>> doc/guides/contributing/documentation.rst:             -- -i --txqflags=0x0
>>> --enable-hw-vlan --enable-lro \
>>> doc/guides/howto/vfd.rst:      testpmd -l 0-7 -n 4 -- -i --txqflags=0
>>> doc/guides/howto/vfd.rst:      testpmd -l 0-7 -n 4 -- -i --txqflags=0
> 
> Hmm.. After a closer look, I think above two --txqflags can't
> be simply removed. In this guide, it needs to demonstrate these
> offloads, e.g. VLAN insertion:
> 
> http://dpdk.org/browse/dpdk/tree/doc/guides/howto/vfd.rst?h=v18.05-rc5#n155
> 
> Right now, unfortunately I'm being busy with preparing a QEMU
> patch set which I need to get it done today. So I'm afraid that
> I don't have time to look into this today.. I'm Sorry.. :(

That is OK, if it is not simply removing, agreed that it should be done by owner
of the code. Thanks for offering support.

> 
> Best regards,
> Tiwei Bie
> 
> 
>>> doc/guides/howto/virtio_user_as_exceptional_path.rst:           -- -i
>>> --txqflags=0x0 --enable-lro \
>>> doc/guides/howto/virtio_user_as_exceptional_path.rst:           -- -i
>>> --txqflags=0x0 --enable-lro \
>>> doc/guides/howto/virtio_user_for_container_networking.rst:            -- -i
>>> --txqflags=0xf00 --disable-hw-vlan