From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 05/30] bus/fslmc: enhance the QBMAN CENA
	mode
Date: Fri, 15 Sep 2017 13:26:34 +0100
Message-ID: <d6f4ea90-967c-962c-adbb-288a4d72b733@intel.com>
References: <1503658183-4078-1-git-send-email-hemant.agrawal@nxp.com>
 <1504860327-18451-1-git-send-email-hemant.agrawal@nxp.com>
 <1504860327-18451-6-git-send-email-hemant.agrawal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: shreyansh.jain@nxp.com
To: Hemant Agrawal <hemant.agrawal@nxp.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 2FFDA2FDD
 for <dev@dpdk.org>; Fri, 15 Sep 2017 14:26:37 +0200 (CEST)
In-Reply-To: <1504860327-18451-6-git-send-email-hemant.agrawal@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/8/2017 9:45 AM, Hemant Agrawal wrote:
> From: Haiying Wang <Haiying.Wang@nxp.com>
> 
> Signed-off-by: Haiying Wang <Haiying.Wang@nxp.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  drivers/bus/fslmc/qbman/qbman_sys.h | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/bus/fslmc/qbman/qbman_sys.h b/drivers/bus/fslmc/qbman/qbman_sys.h
> index 9ea55de..47da595 100644
> --- a/drivers/bus/fslmc/qbman/qbman_sys.h
> +++ b/drivers/bus/fslmc/qbman/qbman_sys.h
> @@ -217,7 +217,6 @@ static inline void qbman_cena_write_complete_wo_shadow(struct qbman_swp_sys *s,
>  #ifdef QBMAN_CENA_TRACE
>  	pr_info("qbman_cena_write_complete(%p:%d:0x%03x)\n",
>  		s->addr_cena, s->idx, offset);
> -	hexdump(cmd, 64);
>  #endif
>  	dcbf(s->addr_cena + offset);
>  }
> @@ -251,11 +250,7 @@ static inline void *qbman_cena_read_wo_shadow(struct qbman_swp_sys *s,
>  {
>  #ifdef QBMAN_CENA_TRACE
>  	pr_info("qbman_cena_read(%p:%d:0x%03x) %p\n",
> -		s->addr_cena, s->idx, offset, shadow);
> -#endif
> -
> -#ifdef QBMAN_CENA_TRACE
> -	hexdump(shadow, 64);
> +		s->addr_cena, s->idx, offset);

Isn't this missing one parameter, previous "shadow" one?

>  #endif
>  	return s->addr_cena + offset;
>  }
>