From mboxrd@z Thu Jan  1 00:00:00 1970
From: Remy Horton <remy.horton@intel.com>
Subject: Re: [PATCH v6 4/4] latencystats: added new library for
	latency stats
Date: Thu, 12 Jan 2017 14:44:29 +0000
Message-ID: <d73e9612-59bf-dcde-9cb9-9fa60b0018f6@intel.com>
References: <1484150594-3758-1-git-send-email-remy.horton@intel.com>
 <1484150594-3758-5-git-send-email-remy.horton@intel.com>
 <8494765.8zaa745I9T@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, olivier.matz@6wind.com
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
 Reshma Pattan <reshma.pattan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 20C52F618
 for <dev@dpdk.org>; Thu, 12 Jan 2017 15:44:33 +0100 (CET)
In-Reply-To: <8494765.8zaa745I9T@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 12/01/2017 13:41, Thomas Monjalon wrote:
> 2017-01-12 00:03, Remy Horton:
>> Add a library designed to calculate latency statistics and report them
>> to the application when queried. The library measures minimum, average and
>> maximum latencies, and jitter in nano seconds. The current implementation
>> supports global latency stats, i.e. per application stats.
>
> Is it specific to ethdev ports?

No (or at least not at the moment).


>> Added new field to mbuf struct to mark the packet arrival time on Rx.
>
> There was another patch adding a timestamp in mbuf:
> 	http://dpdk.org/ml/archives/dev/2016-October/048809.html

Will look into it. Since time is tight will have internal discussion 
whether latency will make it into 17.02..


>> APIs:
>>
>> * Added APIs to initialize and un initialize latency stats
>>   calculation.
>> * Added API to retrieve latency stats names and values.
>
> Why bitrate and latencies are separate libs?

They were developed independently by different people in response to 
seperate requirements.

Reshma went on extended leave, so I took over the latency patch at the 
last moment when development was complete. Aside from rebase-related 
fixups and one printf change it is the last version of her seperate 
patch included verbatim.

..Remy