From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] kni: Fix build on RHEL 8 Date: Tue, 27 Nov 2018 13:38:00 +0000 Message-ID: References: <1543265151-14617-1-git-send-email-mgamal@redhat.com> <26d50d0f-8eb0-608f-9aed-5f3b39a85ff8@intel.com> <1543317202.5400.13.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: mgamal@redhat.com, dev@dpdk.org Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 69DB71B1DD for ; Tue, 27 Nov 2018 14:38:02 +0100 (CET) In-Reply-To: <1543317202.5400.13.camel@redhat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/27/2018 11:13 AM, Mohammed Gamal wrote: > On Tue, 2018-11-27 at 10:55 +0000, Ferruh Yigit wrote: >> On 11/26/2018 8:45 PM, Mohammed Gamal wrote: >>> As RHEL8 beta has been released and is based on recent upstream >>> kernels >>> which don't use ndo_change_mtu_rh74 function. Fix the build so that >>> it >>> doesn't fail because the function is missing >>> >>> Signed-off-by: Mohammed Gamal >>> --- >>>  kernel/linux/kni/compat.h | 3 ++- >>>  1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h >>> index 5aadebb..bc81d0c 100644 >>> --- a/kernel/linux/kni/compat.h >>> +++ b/kernel/linux/kni/compat.h >>> @@ -103,7 +103,8 @@ >>>  #endif >>>   >>>  #if (defined(RHEL_RELEASE_CODE) && \ >>> - (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5))) >>> + (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \ >>> + (RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0))) >>>  #define ndo_change_mtu ndo_change_mtu_rh74 >> >> What RHEL use, can you please confirm it turns back to >> `ndo_change_mtu`, instead >> of something like `ndo_change_mtu_rh8x`? > > There are no such functions in the RHEL8 kernel. You may check the > kernel source code from the SRPM available here: > http://ftp.redhat.com/redhat/rhel/rhel-8-beta/baseos/source/Packages/ke > rnel-4.18.0-32.el8.src.rpm Thanks, I confirm `RH_KABI_RENAME` removed and RHEL8 is using original `ndo_change_mtu` Minor issue, patch title should start with lowercase: 'kni: fix build on RHEL 8' Acked-by: Ferruh Yigit