From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] ethdev: fix iterator default behaviour for
	representors
Date: Thu, 25 Oct 2018 13:59:56 +0100
Message-ID: <d83bf9c9-06b3-66fd-8fe0-026c32c0559d@intel.com>
References: <20181024131321.8409-1-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, ophirmu@mellanox.com
To: Thomas Monjalon <thomas@monjalon.net>,
 Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 14D6A5920
 for <dev@dpdk.org>; Thu, 25 Oct 2018 14:59:58 +0200 (CEST)
In-Reply-To: <20181024131321.8409-1-thomas@monjalon.net>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/24/2018 2:13 PM, Thomas Monjalon wrote:
> The iterator was matching all representors if it was not specified
> in the devargs string. It was a wrong default behaviour.
> 
> If there is no representor parameter in the devargs, the iterator
> should not match any representor port.
> 
> The implementation of the default behaviour would be simpler
> if a "no match" handler is added to rte_kvargs_process().
> As it requires an API breakage, it will be reworked later.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.