From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 2/4] mk: do not build tests by default
Date: Wed, 15 Feb 2017 17:30:48 +0000
Message-ID: <d8920be0-5629-2ee2-fe90-9265fb07b0d6@intel.com>
References: <20170214151326.7554-1-ferruh.yigit@intel.com>
 <20170215152632.25081-1-ferruh.yigit@intel.com>
 <20170215152632.25081-2-ferruh.yigit@intel.com> <3106919.K5kYvNu2Ff@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 John McNamara <john.mcnamara@intel.com>, Keith Wiles <keith.wiles@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 5D893A2F
 for <dev@dpdk.org>; Wed, 15 Feb 2017 18:30:51 +0100 (CET)
In-Reply-To: <3106919.K5kYvNu2Ff@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2/15/2017 4:58 PM, Thomas Monjalon wrote:
> 2017-02-15 15:26, Ferruh Yigit:
>> +.PHONY: test-buid
>> +test-build:
>> +	$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig
>> +	$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk test
> 
> Why not rely on default rule below?
> 
> # all other build targets
> %:
>     $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig
>     $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk $@


Because generic rule is using "rte.sdkbuild.mk $@" rule,
for unit-test, $@ is test-build, but sdkbuild rule is "test"

This can be solved with adding following to sdkbuild.mk:

--- a/mk/rte.sdkbuild.mk
+++ b/mk/rte.sdkbuild.mk
@@ -72,6 +72,9 @@ clean: $(CLEANDIRS)
        $(Q)$(MAKE) -f $(RTE_SDK)/GNUmakefile gcovclean
        @echo Clean complete

+.PHONY: test-build
+test-build: test
+
 .SECONDEXPANSION:
 .PHONY: $(ROOTDIRS-y) test
 $(ROOTDIRS-y) test:


I can update if you think this is better?

Thanks,
ferruh