From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH dpdk-next-net] net/axgbe: fix an assignment
 error in axgbe_dev_info_get()
Date: Thu, 12 Apr 2018 19:02:13 +0100
Message-ID: <d96da069-6b60-5af2-a9f4-5471fcd7fdae@intel.com>
References: <20180409201843.2317-1-rami.rosen@intel.com>
 <CY4PR12MB15099F205035089E59078B62AEBF0@CY4PR12MB1509.namprd12.prod.outlook.com>
 <7da6e5f8-2f1e-c308-c42a-b6ab8a7fee61@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Kumar, Ravi1" <Ravi1.Kumar@amd.com>, Rami Rosen <rami.rosen@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id CA8B61C15C
 for <dev@dpdk.org>; Thu, 12 Apr 2018 20:02:16 +0200 (CEST)
In-Reply-To: <7da6e5f8-2f1e-c308-c42a-b6ab8a7fee61@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/9/2018 3:02 PM, Ferruh Yigit wrote:
> On 4/9/2018 2:56 PM, Kumar, Ravi1 wrote:
>>> This patch fixes a tirvial error in assigning max Rx/Tx queues in axgbe_dev_info_get() of the axgbe PMD driver. 
>>>
>>> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
>>> ---
>>> drivers/net/axgbe/axgbe_ethdev.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c
>>> index 07c1337ac..a9a9fb570 100644
>>> --- a/drivers/net/axgbe/axgbe_ethdev.c
>>> +++ b/drivers/net/axgbe/axgbe_ethdev.c
>>> @@ -355,8 +355,8 @@ axgbe_dev_info_get(struct rte_eth_dev *dev,
>>> 	struct axgbe_port *pdata = dev->data->dev_private;
>>>
>>> 	dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(dev);
>>> -	dev_info->max_rx_queues = pdata->tx_ring_count;
>>> -	dev_info->max_tx_queues = pdata->rx_ring_count;
>>> +	dev_info->max_rx_queues = pdata->rx_ring_count;
>>> +	dev_info->max_tx_queues = pdata->tx_ring_count;
>>> 	dev_info->min_rx_bufsize = AXGBE_RX_MIN_BUF_SIZE;
>>> 	dev_info->max_rx_pktlen = AXGBE_RX_MAX_BUF_SIZE;
>>> 	dev_info->max_mac_addrs = AXGBE_MAX_MAC_ADDRS;
>>> --
>>> 2.14.3
>>>
>>
>> Thanks a lot Remi. Wonderful catch. 
> 
> I am adding your explicit ack for the patch:
> Acked-by: Ravi Kumar <ravi1.kumar@amd.com>

Squashed into relevant commit in next-net, thanks.