From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v2] devbind: don't display non-existent device categories Date: Fri, 23 Nov 2018 09:23:53 +0000 Message-ID: References: <07b7c67be5adc770b028212ef8918d4ae8f11255.1542127066.git.anatoly.burakov@intel.com> <9ee6c634ef079abef070a72fff26d06e364a609b.1542623365.git.anatoly.burakov@intel.com> <2321597.iDRxu9RN5K@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, david.hunt@intel.com, john.mcnamara@intel.com, ferruh.yigit@intel.com, keith.wiles@intel.com To: Thomas Monjalon Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 53B5D2BD5 for ; Fri, 23 Nov 2018 10:23:56 +0100 (CET) In-Reply-To: <2321597.iDRxu9RN5K@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 22-Nov-18 5:12 PM, Thomas Monjalon wrote: > 19/11/2018 11:33, Anatoly Burakov: >> If there aren't any devices of a particular category on user's >> system, we still display them, which is bad for usability. Fix >> devbind to not print out a category unless there are devices in >> it. >> >> Signed-off-by: Anatoly Burakov >> Reviewed-by: David Hunt > > Applied, thanks > > I think we can strip output more and remove "no detected" messages. > I had an idea to do that, but for now i decided to keep it for the purposes of providing just enough useful information to the user with little expense. -- Thanks, Anatoly