From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
Subject: Re: [PATCH v4 2/5] ethdev: introduce new tunnel VXLAN-GPE
Date: Tue, 17 Apr 2018 09:54:48 +0100
Message-ID: <daf09c5c-7b3a-17f2-6616-a060f4b3dfec@intel.com>
References: <20180413110218.105894-1-xuemingl@mellanox.com>
 <20180413110218.105894-3-xuemingl@mellanox.com> <2345236.0ahlb2178t@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
 Shahaf Shuler <shahafs@mellanox.com>, Olivier Matz <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>, Xueming Li <xuemingl@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id CC8D68E7E
 for <dev@dpdk.org>; Tue, 17 Apr 2018 10:54:54 +0200 (CEST)
In-Reply-To: <2345236.0ahlb2178t@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 16/04/2018 23:23, Thomas Monjalon wrote:
> 13/04/2018 13:02, Xueming Li:
>> +struct vxlan_gpe_hdr {
>> +	uint8_t vx_flags; /**< flag (8). */
>> +	uint8_t reserved[2]; /**< Reserved (16). */
>> +	uint8_t proto; /**< next-protocol (8). */
>> +	uint32_t vx_vni;   /**< VNI (24) + Reserved (8). */
>> +} __attribute__((__packed__));
> minor nit: the field comments could be aligned
>
Once addressed the above comment

Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>