From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Rybchenko Subject: Re: [PATCH 5/5] sfc: don't use RTE_LOGTYPE_PMD Date: Thu, 28 Feb 2019 09:49:22 +0300 Message-ID: References: <20190226213424.10567-1-stephen@networkplumber.org> <20190226213424.10567-6-stephen@networkplumber.org> <585db3f2-d9e6-1efd-b05f-7050758423a6@intel.com> <20190227103043.3b62103b@shemminger-XPS-13-9360> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Cc: Ferruh Yigit , , Igor Romanov To: Stephen Hemminger Return-path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 9969C4C8F for ; Thu, 28 Feb 2019 07:49:34 +0100 (CET) In-Reply-To: <20190227103043.3b62103b@shemminger-XPS-13-9360> Content-Language: en-GB List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/27/19 9:30 PM, Stephen Hemminger wrote: > On Wed, 27 Feb 2019 14:24:21 +0300 > Andrew Rybchenko wrote: > >> On 2/27/19 2:21 PM, Ferruh Yigit wrote: >>> On 2/26/2019 9:34 PM, Stephen Hemminger wrote: >>>> The sfc driver was still using RTE_LOGTYPE_PMD which was superseded >>>> by local logging. >>>> >>>> Signed-off-by: Stephen Hemminger >>>> --- >>>> drivers/net/sfc/sfc.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/net/sfc/sfc.c b/drivers/net/sfc/sfc.c >>>> index 898603884fa0..2cd7126015fd 100644 >>>> --- a/drivers/net/sfc/sfc.c >>>> +++ b/drivers/net/sfc/sfc.c >>>> @@ -1115,12 +1115,12 @@ sfc_register_logtype(const struct rte_pci_addr *pci_addr, >>>> ++lt_prefix_str_size; /* Reserve space for prefix separator */ >>>> lt_str_size_max = lt_prefix_str_size + PCI_PRI_STR_SIZE + 1; >>>> } else { >>>> - return RTE_LOGTYPE_PMD; >>>> + return sfc_logtype_driver; >>>> } >>>> >>>> lt_str = rte_zmalloc("logtype_str", lt_str_size_max, 0); >>>> if (lt_str == NULL) >>>> - return RTE_LOGTYPE_PMD; >>>> + return sfc_logtype_driver; >>>> >>>> strncpy(lt_str, lt_prefix_str, lt_prefix_str_size); >>>> lt_str[lt_prefix_str_size - 1] = '.'; >>>> >>> Overall I think it is good idea to remove RTE_LOGTYPE_PMD, but sfc has a few >>> more usage of it around same manner, as a fallback value if allocating dynamic >>> one fails. >>> >>> >>> Andrew, >>> >>> Can be possible to update this sfc patch to completely eliminate RTE_LOGTYPE_PMD >>> usage? What do you think? >>> >>> Thanks, >>> ferruh >> I'm OK to use  sfc_logtype_driverif dynamic log type register fails, but >> what should I do if sfc_logtype_driverregister fails? >> >> Andrew. > I don't like drivers that try to do something different than every other driver in DPDK. > The solarflare driver is doing lots of extra effort to have multiple fine grain log types. > Not sure if there is any value to this. In a real world situation for diagnosis you would > want to turn on logs across everything in the driver, then filter as needed later. We really use logging configuration facilities which we have in the driver and, thanks to dynamic logging design (IMO really good design), both your and our logging usage scenarios can coexist. Andrew.