From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4 2/3] app/testpmd: add packet dump callback
 functions
Date: Thu, 11 Oct 2018 15:58:09 +0100
Message-ID: <db7e6789-82e8-9c27-4acf-d726d248eab5@intel.com>
References: <1537793304-27883-1-git-send-email-rasland@mellanox.com>
 <1538897848-1693-1-git-send-email-rasland@mellanox.com>
 <1538897848-1693-2-git-send-email-rasland@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>,
 Shahaf Shuler <shahafs@mellanox.com>,
 "Xueming(Steven) Li" <xuemingl@mellanox.com>, Ori Kam <orika@mellanox.com>,
 "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
 "david.marchand@6wind.com" <david.marchand@6wind.com>,
 "bernard.iremonger@intel.com" <bernard.iremonger@intel.com>
To: Raslan Darawsheh <rasland@mellanox.com>,
 "jingjing.wu@intel.com" <jingjing.wu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 4EBEF1B56D
 for <dev@dpdk.org>; Thu, 11 Oct 2018 16:58:13 +0200 (CEST)
In-Reply-To: <1538897848-1693-2-git-send-email-rasland@mellanox.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/7/2018 8:38 AM, Raslan Darawsheh wrote:
> add new rx/tx callback functions to be used for dumping the packets.
> 
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>

<...>

> +uint16_t
> +dump_rx_pkts(uint16_t port_id, uint16_t queue, struct rte_mbuf *pkts[],
> +	     uint16_t nb_pkts, __rte_unused uint16_t max_pkts,
> +	     __rte_unused void *user_param)
> +{
> +	dump_pkt_burst(port_id, queue, pkts, nb_pkts, 1);

You can add an enum or define to clarify what last param 0/1 is.

> +	return nb_pkts;
> +}
> +
> +uint16_t
> +dump_tx_pkts(uint16_t port_id, uint16_t queue, struct rte_mbuf *pkts[],
> +	     uint16_t nb_pkts, __rte_unused void *user_param)
> +{
> +	dump_pkt_burst(port_id, queue, pkts, nb_pkts, 0);
> +	return nb_pkts;
> +}
>