From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v3] doc: announce ethdev CRC strip flag deprecation Date: Tue, 17 Apr 2018 14:36:17 +0100 Message-ID: References: <20180321194730.52068-1-ferruh.yigit@intel.com> <20180417131221.181117-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Thomas Monjalon , Shahaf Shuler To: Neil Horman , John McNamara , Marko Kovacevic Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E2852D003 for ; Tue, 17 Apr 2018 15:36:20 +0200 (CEST) In-Reply-To: <20180417131221.181117-1-ferruh.yigit@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/17/2018 2:12 PM, Ferruh Yigit wrote: > Make CRC stripping default behavior, deprecate flag > DEV_RX_OFFLOAD_CRC_STRIP. > > Signed-off-by: Ferruh Yigit > > --- > v2: > * Make CRC behavior active in this release > > v3: > * Distribute switch into next two releases for more smooth transition > v18.08: add new flag to keep crc, and implement this in PMDs > v18.11: remove crc strip flag and make default behavior to strip crc > --- > doc/guides/rel_notes/deprecation.rst | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index fd9def20c..3ee1bd05e 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -100,6 +100,26 @@ Deprecation Notices > between the VF representor and the VF or the parent PF. Those new fields > are to be included in ``rte_eth_dev_info`` struct. > > +* ethdev: A new offloading flag ``DEV_RX_OFFLOAD_KEEP_CRC`` will be added in v18.08, > + This will replace the usage of not setting ``DEV_RX_OFFLOAD_CRC_STRIP`` flag > + and will be implemented in PMDs accordingly. > + In v18.08 both ``DEV_RX_OFFLOAD_KEEP_CRC`` and ``DEV_RX_OFFLOAD_CRC_STRIP`` flags > + will be available, usage will be: > + ``CRC_STRIP``: Strip CRC from packet > + ``KEEP_CRC``: Keep CRC in packet > + Both ``CRC_STRIP`` & ``KEEP_CRC``: Invalid > + No flag: Keep CRC in packet > + > +* ethdev: In v18.11 ``DEV_RX_OFFLOAD_CRC_STRIP`` offload flag will be removed, default > + behavior without any flag will be changed to CRC strip. > + To keep CRC ``DEV_RX_OFFLOAD_KEEP_CRC`` flag is required. > + ``KEEP_CRC``: Keep CRC in packet > + No flag: Strip CRC from packet > + > +* ethdev: Make CRC stripping default behavior in v18.05 without any flag > + and remove flag completely in v18.08 > + ``DEV_RX_OFFLOAD_CRC_STRIP`` flag will be removed. > + This last part is git artifact, I will send a new version to fix it. > * i40e: The default flexible payload configuration which extracts the first 16 > bytes of the payload for RSS will be deprecated starting from 18.02. If > required the previous behavior can be configured using existing flow >