From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH v4 03/41] bus/dpaa: add compatibility and helper macros Date: Tue, 26 Sep 2017 18:13:55 +0530 Message-ID: References: <20170823141213.25476-1-shreyansh.jain@nxp.com> <20170909112132.13936-1-shreyansh.jain@nxp.com> <20170909112132.13936-4-shreyansh.jain@nxp.com> <916531df-edb4-d0fe-cb86-32cedb6fc46a@intel.com> <690be1c8-67d1-31e0-b1dc-4b270b1f8519@nxp.com> <3bf46b37-6bcb-b6c5-62ea-5632f81f518a@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Cc: , To: Ferruh Yigit Return-path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0078.outbound.protection.outlook.com [104.47.36.78]) by dpdk.org (Postfix) with ESMTP id 291971B1B3 for ; Tue, 26 Sep 2017 14:33:05 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tuesday 19 September 2017 07:27 PM, Shreyansh Jain wrote: > On Tuesday 19 September 2017 07:10 PM, Ferruh Yigit wrote: >> On 9/19/2017 2:18 PM, Shreyansh Jain wrote: >>> On Monday 18 September 2017 08:19 PM, Ferruh Yigit wrote: >>>> On 9/9/2017 12:20 PM, Shreyansh Jain wrote: >>>>> From: Hemant Agrawal >>>>> >>>>> Linked list, bit operations and compatibility macros. >>>>> >>>>> Signed-off-by: Geoff Thorpe >>>>> Signed-off-by: Hemant Agrawal >>>> [...] >>>>> + */ >>>> >> >> <...> >> >>>>> + >>>>> +#ifndef __DPAA_LIST_H >>>>> +#define __DPAA_LIST_H >>>>> + >>>>> +/****************/ >>>>> +/* Linked-lists */ >>>>> +/****************/ >>>> >>>> Do we need to maintain a linked list implementation, why no just use >>>> sys/queue.h ones as done many places in DPDK? >>>> >>>>> + >>>>> +struct list_head { >>>>> +    struct list_head *prev; >>>>> +    struct list_head *next; >>>>> +}; >>>>> + >>>> >>>> <...> >>>> >>> >>> The underlying DPAA infrastructure code is shared between kernel and >>> userspace. That is why, changing the internal headers (for example, >>> using RTE_* queues) is something I want to avoid until absolutely >>> necessary. The outer layers (drivers/*/dpaa/) are something I am >>> trying to keep as close to possible to DPDK. >> >> I understand you want to escape from maintaining a copy of common files >> for DPDK, this has been done by many drivers, as not changing "base" >> files, this makes sense. >> >> But for this case, file is "dpaa_list.h" and as far as I can see all it >> has is linked list implementation, this looked easy to exclude, but if >> not you can ignore the comment. > > Got your point. I will respin and see how much is the impact. > Thanks for inputs. I tried to work around the dpaa_list.h use in DPAA code - but, the changes are subtle but large in number - though, restricted only to base framework. I would prefer to skip this for a while as the driver is stable now. I would probably do this change in a incremental manner to keep it traceable. Ferruh, Is that OK with you?