From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] test: fix broken "make test" Date: Tue, 12 Feb 2019 09:36:47 +0000 Message-ID: References: <20190211183859.12314-1-ramirose@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: naga.sureshx.somarowthu@intel.com, reshma.pattan@intel.com, dpdk-stable To: Rami Rosen , dev@dpdk.org Return-path: In-Reply-To: <20190211183859.12314-1-ramirose@gmail.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/11/2019 6:38 PM, Rami Rosen wrote: > This patch fixes a broken build; when running > make test > we get the following error: > ... > Traceback (most recent call last): > File "/work/src/dpdk-19.02/test/test/autotest.py", line 49, in > num_fails = runner.run_all_tests() > File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 345, in > run_all_tests > self.parallel_tests) > File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 264, in > __filter_test > test_cmd = test["Command"] > KeyError: 'Command' > ... > The reason is that the pdump autotest entry uses "Comamnd" > instead of "Command"; this patch fixes it. > > Bugzilla ID: 205 > Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library") > Signed-off-by: Rami Rosen Reviewed-by: Ferruh Yigit Good catch! But it seems 19.02 released autotest broken, so this needs to be backported to 19.02: Cc: stable@dpdk.org Thomas, What do you think adding autotest into DPDK community lab testing? I will bring the the suggestion in next meeting.