From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v5] net/kni: calc mbuf&mtu according to given mb_pool Date: Mon, 25 Mar 2019 21:11:04 +0000 Message-ID: References: <1553429745-10169-1-git-send-email-lironh@marvell.com> <1553546882-22702-1-git-send-email-lironh@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, walan@marvell.com To: lironh@marvell.com Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 4ACA92BD3 for ; Mon, 25 Mar 2019 22:11:07 +0100 (CET) In-Reply-To: <1553546882-22702-1-git-send-email-lironh@marvell.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/25/2019 8:48 PM, lironh@marvell.com wrote: > From: Liron Himi > > - mbuf_size and mtu are now being calculated according > to the given mb-pool. > > - max_mtu is now being set according to the given mtu > > the above two changes provide the ability to work with jumbo frames > > Signed-off-by: Liron Himi > --- <...> > @@ -187,6 +187,8 @@ The ``struct rte_kni_conf`` structure contains fields which allow the > user to specify the interface name, set the MTU size, set an explicit or > random MAC address and control the affinity of the kernel Rx thread(s) > (both single and multi-threaded modes). > +by default kni sample gets mtu from matching device, and for kni pmd it > +is derived from mbuf buffer length, Hi Liron, I can see you copy/pasted the comment to the doc, but the intention was not to use it exactly. This is a public documentation, can you please correct the wording, cases and punctuation, please make it something documentation quality.