From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] ethdev: force RSS offload rules again Date: Sun, 3 Jun 2018 15:15:09 +0100 Message-ID: References: <20180531132245.19424-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , "Xueming(Steven) Li" , Wei Dai , Qi Zhang , Andrew Rybchenko To: Shahaf Shuler , Thomas Monjalon Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id F20853195 for ; Sun, 3 Jun 2018 16:15:13 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/3/2018 11:41 AM, Shahaf Shuler wrote: > Thursday, May 31, 2018 4:23 PM, Ferruh Yigit: >> Subject: [PATCH] ethdev: force RSS offload rules again >> >> PMDs should provide supported RSS hash functions via >> dev_info.flow_type_rss_offloads variable. >> >> There is a check in ethdev if requested RSS hash function is supported by >> PMD or not. >> This check has been relaxed in previous release to not return an error when a >> non supported has function requested [1], this has been done to not break >> the applications. >> >> Adding the error return back. >> PMDs need to provide correct list of supported hash functions and >> applications need to take care this information before configuring the RSS >> otherwise they will get an error from APIs: >> rte_eth_dev_rss_hash_update() >> rte_eth_dev_configure() > > Are the current app/examples in DPDK tree behave accordingly? I tried a few which were good but I don't know about all. That is why we should merge this patch early so that we can detect and fix ones fails.