From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32642C433E0 for ; Wed, 27 Jan 2021 12:44:46 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 842EC207A3 for ; Wed, 27 Jan 2021 12:44:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 842EC207A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7469140D24; Wed, 27 Jan 2021 13:44:44 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id B2A83140D23; Wed, 27 Jan 2021 13:44:43 +0100 (CET) IronPort-SDR: SgR0DFzhedEYOdKknPX12QMilNfI+YI+7Wq0CelHsV3hO73KuInr/VUALgTd0l+I1WBIOEbUi7 yLSADa4oMrYA== X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="264884995" X-IronPort-AV: E=Sophos;i="5.79,379,1602572400"; d="scan'208";a="264884995" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 04:44:42 -0800 IronPort-SDR: B6LK6nuHbNQ7GuV2IyqyW/K71Y83ekAOrSXKQBTzwMEWDDmdFlAwR8zyQsUl95egg/9noYLvu5 f12bAndVVomw== X-IronPort-AV: E=Sophos;i="5.79,379,1602572400"; d="scan'208";a="430088495" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.208.215]) ([10.213.208.215]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 04:44:39 -0800 To: Viacheslav Ovsiienko , dev@dpdk.org Cc: rasland@nvidia.com, matan@nvidia.com, orika@nvidia.com, thomas@monjalon.net, akozyrev@nvidia.com, stable@dpdk.org References: <1608311697-31529-1-git-send-email-viacheslavo@nvidia.com> <1611335529-26503-1-git-send-email-viacheslavo@nvidia.com> <1611335529-26503-2-git-send-email-viacheslavo@nvidia.com> From: Ferruh Yigit Message-ID: Date: Wed, 27 Jan 2021 12:44:35 +0000 MIME-Version: 1.0 In-Reply-To: <1611335529-26503-2-git-send-email-viacheslavo@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/2] net/mlx5: optimize inline mbuf freeing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/22/2021 5:12 PM, Viacheslav Ovsiienko wrote: > The mlx5 PMD supports packet data inlining by pushing data > to the transmit descriptor. If packet is short enough and all > data are inline, the mbuf is not needed for data send anymore > and can be freed. > > The mbuf free was performed in the most inner loop building > the transmit descriptors. This patch postpones the mbuf free > transaction to the tx_burst routine exit, optimizing the loop > and allowing the bulk freeing for the multiple mbufs in single > pool API call. > > Cc: stable@dpdk.org > Hi Slava, This patch is optimization for inline mbufs, right, it is not a fix, should it be backported? cc'ed LTS maintainers. I am dropping the stable to for now in the next-net, can add it later based on discussion result. > Signed-off-by: Viacheslav Ovsiienko