From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3] doc: update flow filtering document
Date: Tue, 6 Feb 2018 14:18:50 +0000
Message-ID: <de69660b-9bbf-d4cb-8acb-a09a7765dbce@intel.com>
References: <20180130074431.116094-1-wei.zhao1@intel.com>
 <20180131021227.129117-1-wei.zhao1@intel.com>
 <37e0c4ff-3370-27d7-fe03-6889b5f4c35c@intel.com>
 <B27915DBBA3421428155699D51E4CFE23EEA75F2@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "stable@dpdk.org" <stable@dpdk.org>,
 "orika@mellanox.com" <orika@mellanox.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>,
 "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <B27915DBBA3421428155699D51E4CFE23EEA75F2@IRSMSX103.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2/5/2018 3:31 PM, Mcnamara, John wrote:
> 
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Wednesday, January 31, 2018 5:24 PM
>> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
>> Cc: Mcnamara, John <john.mcnamara@intel.com>; stable@dpdk.org;
>> orika@mellanox.com
>> Subject: Re: [dpdk-dev] [PATCH v3] doc: update flow filtering document
>>
>> On 1/31/2018 2:12 AM, Wei Zhao wrote:
>>> This patch will update example application of flow_filtering document.
>>> It add Tx queues configuration related comment.
>>>
>>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>>> Reviewed-by: Ori Kam <orika@mellanox.com>
>>
>> Hi Wei,
>>
>> This patch is causing documentation warning:
>> ...dpdk/doc/guides/sample_app_ug/flow_filtering.rst:161: WARNING: Could
>> not lex literal_block as "c". Highlighting skipped.
> 
> Hi,
> 
> The reason for the warning was due to 2 instances like the following:
> 
> +                            rte_exit(EXIT_FAILURE,
> +                                    ":: Rx queue setup failed: err=%d,
> +                                    port=%u\n",
> +                                    ret, port_id);
>                     
> 
> Here the error string extends over 2 lines so the error message will print out a newline and a lot of whitespace in the middle of the string. It should probably
> be something like the following:
> 
> +                            rte_exit(EXIT_FAILURE,
> +                                    ":: Rx queue setup failed: err=%d, "
> +                                    "port=%u\n",
> +                                    ret, port_id);
>                     
> or just:
> 
> +                            rte_exit(EXIT_FAILURE,
> +                                    ":: Rx queue setup failed: err=%d, port=%u\n",
> +                                    ret, port_id);

Thanks for clarifying this John.

Patch pulled from next-net-intel to next-net and suggested fix applied on next-net.