From mboxrd@z Thu Jan 1 00:00:00 1970 From: Declan Doherty Subject: Re: [PATCH] examples/l2fwd-crypto: out-of-bounds read Date: Thu, 30 Jun 2016 10:15:16 +0100 Message-ID: References: <1467202744-4140-1-git-send-email-slawomirx.mrozowicz@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Slawomir Mrozowicz Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8138F2935 for ; Thu, 30 Jun 2016 11:20:10 +0200 (CEST) In-Reply-To: <1467202744-4140-1-git-send-email-slawomirx.mrozowicz@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 29/06/16 13:19, Slawomir Mrozowicz wrote: > Overrunning array crypto_statistics of 32 64-byte elements > at element index 63 using index cdevid. > Fixed by extend crypto_statistics array. > > Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application") > Coverity ID 120145 > > Signed-off-by: Slawomir Mrozowicz > --- > examples/l2fwd-crypto/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c > index 8dc616d..70fada5 100644 > --- a/examples/l2fwd-crypto/main.c > +++ b/examples/l2fwd-crypto/main.c > @@ -243,7 +243,7 @@ struct l2fwd_crypto_statistics { > } __rte_cache_aligned; > > struct l2fwd_port_statistics port_statistics[RTE_MAX_ETHPORTS]; > -struct l2fwd_crypto_statistics crypto_statistics[RTE_MAX_ETHPORTS]; > +struct l2fwd_crypto_statistics crypto_statistics[RTE_CRYPTO_MAX_DEVS]; > > /* A tsc-based timer responsible for triggering statistics printout */ > #define TIMER_MILLISECOND 2000000ULL /* around 1ms at 2 Ghz */ > Acked-by: Declan Doherty